Update settings for Shields, and Privacy and security #36859

rebron · 2024-03-15T22:03:00Z

Description

Follow-up to #36363

In brave://settings/shields:

Move Show the number of blocked items on the Shields icon setting above Trackers & ads blocking
Move Auto-redirect AMP pages, Auto-redirect tracking URLs, and Prevent sites from fingerprinting me based on my language to brave://settings/privacy. Right below Use Google services for push messaging

In brave://settings/privacy:

Move Clear browsing data, Security, and Site and Shields settings to the top of the Privacy section.
Create a new section called Data collection below the Tor windows section and move the Allow p3a, Allow ping, and Allow diagnostic reports into that section.
Remove Safety check section.

Design

Reproduces how often:

n/a

Brave version (brave://version info)

Version/Channel Information:

Can you reproduce this issue with the current release?
Can you reproduce this issue with the beta channel?
Can you reproduce this issue with the nightly channel?

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? n/a
Does the issue resolve itself when disabling Brave Rewards? n/a
Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc: @ShivanKaul, @fmarier, @diracdeltas

The text was updated successfully, but these errors were encountered:

ShivanKaul · 2024-03-18T20:18:11Z

@emerick I don't know if you'd gotten to the 3rd point in the issue for changes in brave://settings/shields, but just wanted to call out that I added the requirement for the sub-label for Block cookies.

Move Third-party cookies from brave://settings/privacy to brave://settings/shields, fully replacing Block cookies and the drop down menu in favor of this link to the sub-menu. Keep the top-level label Block cookies and the sub-label from Third-party cookies (reflecting current status).

emerick · 2024-03-20T18:02:20Z

@rebron This is just about done (all checked items are finished), except I haven't removed the original "Block cookies" dropdown as you mentioned that it still needs to be supported somewhere. Let me know if you have any thoughts as far as where it should go. At the moment, I just have it in brave://settings/shields right above the "Block cookies >" entry.

MadhaviSeelam · 2024-04-04T19:50:48Z

Verification PASSED using

Brave | 1.66.59 Chromium: 123.0.6312.105 (Official Build) nightly (64-bit)
-- | --
Revision | 2714c7ac837e7b7693b1b56a82effdf57e04fe09
OS | Windows 11 Version 23H2 (Build 22631.3374)

Installed 1.66.59
launched Brave
opened brave://settings/shields
opened brave://settings/privacy

Case 1: brave://settings/shields

Confirmed Show the number of blocked items on the Shields icon setting is shown above Trackers & ads blocking
Confirmed the toggle off/on to show blocked items work as expected

`1.64.116`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Confirmed following settings are moved from brave://settings/shields to brave://settings/privacy and are shown right below Use Google services for push messaging
- Auto-redirect AMP pages
- Auto-redirect tracking URLs
- Prevent sites from fingerprinting me based on my language
Confirmed Learn more links work as expected
Note: Support pages need an update

`1.64.116`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Auto-redirect AMP pages

opened brave://settings/privacy
enabled Auto-redirect AMP pages setting as default
loaded https://shivankaul.com/brave/de-amp/test-amp-lightning-empty-attribute.html
Confirmed Auto-redirect AMP pages toggle on/off work as expected

example	example

Case 2: brave://settings/privacy

Confirmed following settings moved from bottom to the top of the Privacy and Security section in the brave://settings/privacy
- Clear browsing data
- Security
- Site and Shields

`1.64.116`	`1.66.69`(light theme	`1.66.69` (dark theme)

Data collection

Confirmed a new section called Data collection displayed below the Tor windows section and following settings are shown in the section in the brave://settings/privacy
- Allow privacy-preserving product analytics (P3A)
- Automatically send daily usage ping to Brave
- Automatically send diagnostic reports
Confirmed toggle on/off work as expected for above settings

`1.64.116`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Safety check section

Confirmed Safety check section is no longer shown at the bottom of brave://settings/privacy page

1.64.116	1.66.59

stephendonner · 2024-04-29T18:34:02Z

Verification `PASSED` using

Brave | 1.66.94 Chromium: 124.0.6367.91 (Official Build) beta (x86_64)
-- | --
Revision | 1574096f9d2bcb69c3654cb4437217121ee9600b
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

Installed 1.66.94
launched Brave
opened brave://settings/shields
opened brave://settings/privacy

Case 1: brave://settings/shields

Confirmed Show the number of blocked items on the Shields icon setting is shown above Trackers & ads blocking
Confirmed the toggle off/on to show blocked items work as expected

`1.65.123`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Confirmed following settings are moved from brave://settings/shields to brave://settings/privacy and are shown right below Use Google services for push messaging
- Auto-redirect AMP pages
- Auto-redirect tracking URLs
- Prevent sites from fingerprinting me based on my language
Confirmed Learn more links work as expected
Note: Support pages need an update

`1.65.123`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Auto-redirect AMP pages

opened brave://settings/privacy
enabled Auto-redirect AMP pages setting as default
loaded https://shivankaul.com/brave/de-amp/test-amp-lightning-empty-attribute.html
Confirmed Auto-redirect AMP pages toggle on/off work as expected

example	example

Case 2: brave://settings/privacy

Confirmed following settings moved from bottom to the top of the Privacy and Security section in the brave://settings/privacy
- Clear browsing data
- Security
- Site and Shields

`1.65.123`	`1.66.69`(light theme	`1.66.69` (dark theme)

Data collection

Confirmed a new section called Data collection displayed below the Tor windows section and following settings are shown in the section in the brave://settings/privacy
- Allow privacy-preserving product analytics (P3A)
- Automatically send daily usage ping to Brave
- Automatically send diagnostic reports
Confirmed toggle on/off work as expected for above settings

`1.65.123`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Safety check section

Confirmed Safety check section is no longer shown at the bottom of brave://settings/privacy page

1.65.123	1.66.59

stephendonner · 2024-04-30T01:38:21Z

Verified `PASSED` using

Brave | 1.66.94 Chromium: 124.0.6367.91 (Official Build) beta (64-bit) 
-- | --
Revision | 1574096f9d2bcb69c3654cb4437217121ee9600b
OS | Linux

Steps:

Installed 1.66.94
launched Brave
opened brave://settings/shields
opened brave://settings/privacy

Case 1: brave://settings/shields

Confirmed Show the number of blocked items on the Shields icon setting is shown above Trackers & ads blocking
Confirmed the toggle off/on to show blocked items work as expected

`1.65.123`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Confirmed following settings are moved from brave://settings/shields to brave://settings/privacy and are shown right below Use Google services for push messaging
- Auto-redirect AMP pages
- Auto-redirect tracking URLs
- Prevent sites from fingerprinting me based on my language
Confirmed Learn more links work as expected
Note: Support pages need an update

`1.65.123`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Auto-redirect AMP pages

opened brave://settings/privacy
enabled Auto-redirect AMP pages setting as default
loaded https://shivankaul.com/brave/de-amp/test-amp-lightning-empty-attribute.html
Confirmed Auto-redirect AMP pages toggle on/off work as expected

example	example

Case 2: brave://settings/privacy

Confirmed following settings moved from bottom to the top of the Privacy and Security section in the brave://settings/privacy
- Clear browsing data
- Security
- Site and Shields

`1.65.123`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Data collection

Confirmed a new section called Data collection displayed below the Tor windows section and following settings are shown in the section in the brave://settings/privacy
- Allow privacy-preserving product analytics (P3A)
- Automatically send daily usage ping to Brave
- Automatically send diagnostic reports
Confirmed toggle on/off work as expected for above settings

`1.65.123`	`1.66.69`(light theme)	`1.66.69` (dark theme)

Safety check section

Confirmed Safety check section is no longer shown at the bottom of brave://settings/privacy page

1.65.123	1.66.59

rebron added OS/Desktop feature/settings labels Mar 15, 2024

rebron assigned emerick Mar 15, 2024

rebron added release-notes/include QA/Yes design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Mar 15, 2024

emerick mentioned this issue Mar 18, 2024

Reorganize privacy and shields settings brave/brave-core#22662

Merged

24 tasks

rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 18, 2024

rebron added this to In progress in Settings Mar 19, 2024

emerick closed this as completed in brave/brave-core#22662 Mar 22, 2024

emerick added this to the 1.66.x - Nightly milestone Mar 22, 2024

rebron moved this from In progress to Completed in Settings Mar 26, 2024

rebron mentioned this issue Apr 3, 2024

follow-up to #36859, Remove redundant Block cookies setting #37305

Closed

MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 4, 2024

MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 4, 2024

stephendonner mentioned this issue Apr 11, 2024

Upgrade from Chromium 123 to Chromium 124 #36346

Closed

LaurenWags added the QA/Test-All-Platforms label Apr 25, 2024

stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 29, 2024

stephendonner added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 30, 2024

rebron mentioned this issue May 2, 2024

Settings re-organization for Privacy/Security/Shields sections #36363

Closed

LaurenWags mentioned this issue May 14, 2024

Desktop Release Notes for 1.66.x Release #38323

Closed

rebron removed this from Completed in Settings May 16, 2024

rebron mentioned this issue May 16, 2024

[META] Improve brave://settings with updates to order and placement of several new settings #16621

Open

13 tasks

This was referenced Jun 5, 2024

Change navigation for "Removed permissions for x unused site(s)" from hamburger menu #38825

Open

[CR 126] Remove or update "Safety Check" section in brave://settings/content #38827

Open

rebron mentioned this issue Jun 5, 2024

[CR 126] Add Safety check section back to brave://settings/privacy #38850

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update settings for Shields, and Privacy and security #36859

Update settings for Shields, and Privacy and security #36859

rebron commented Mar 15, 2024 •

edited

ShivanKaul commented Mar 18, 2024

emerick commented Mar 20, 2024

MadhaviSeelam commented Apr 4, 2024 •

edited

stephendonner commented Apr 29, 2024 •

edited

stephendonner commented Apr 30, 2024 •

edited

Update settings for Shields, and Privacy and security #36859

Update settings for Shields, and Privacy and security #36859

Comments

rebron commented Mar 15, 2024 • edited

Description

Design

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

ShivanKaul commented Mar 18, 2024

emerick commented Mar 20, 2024

MadhaviSeelam commented Apr 4, 2024 • edited

stephendonner commented Apr 29, 2024 • edited

Verification PASSED using

Steps:

stephendonner commented Apr 30, 2024 • edited

Verified PASSED using

Steps:

rebron commented Mar 15, 2024 •

edited

MadhaviSeelam commented Apr 4, 2024 •

edited

stephendonner commented Apr 29, 2024 •

edited

Verification `PASSED` using

stephendonner commented Apr 30, 2024 •

edited

Verified `PASSED` using