Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions from the default adblock engine should be applied to the additional engine #36940

Closed
antonok-edm opened this issue Mar 19, 2024 · 0 comments · Fixed by brave/brave-core#22681
Assignees
Labels
bug feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include

Comments

@antonok-edm
Copy link
Contributor

Our way of protecting 1st-party content in default blocking has been to not check the default engine for first-party requests. But, it was discovered that if the default engine contains an exception, it isn't respected (because it's not checked at all). So we still need to check the default engine, but only to look for exceptions.

@ryanbr has been working around this for now by manually importing exceptions to Brave's first-party list. However, the browser should be able to handle this automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants