Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an ability to dictate Leo prompt #37053

Closed
SergeyZhukovsky opened this issue Mar 25, 2024 · 3 comments · Fixed by brave/brave-core#22748
Closed

Add an ability to dictate Leo prompt #37053

SergeyZhukovsky opened this issue Mar 25, 2024 · 3 comments · Fixed by brave/brave-core#22748
Assignees
@SergeyZhukovsky
Labels
browser-ai OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.64.x - Release #2

Comments

@SergeyZhukovsky
Copy link
Member

We want to use Android API for voice recognition. Basically a new microphone icon has to be added into the input prompt. We should recognise the prompt and submit it to Leo for a response.
@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality browser-ai labels Mar 25, 2024
@SergeyZhukovsky SergeyZhukovsky self-assigned this Mar 25, 2024
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Mar 25, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Mar 25, 2024
This was referenced Mar 26, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.64.113 or higher for 1.64.x verification 👍

@Uni-verse
Copy link
Collaborator

Uni-verse commented Mar 27, 2024 •
edited

Verified on Samsung Galaxy S21 using version:

Brave	1.64.113 Chromium: 123.0.6312.86 (Official Build) (64-bit) 
Revision	4e20399c0c5e3cbbb80dd1119122400e08259feb
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Verified voice dictation is working for Leo prompt when enabling the microphone.
  • Verified permission prompt is shown when first interacting with the microphone.
  • Verified there are no issues using voice dictation repeatedly for Leo.
  • Verified there are no issues using keyboard for Leo chat.

Encountered: #37176

Example Example Example
Screenshot 2024-03-27 at 10 40 22 AM Screenshot 2024-03-27 at 10 49 20 AM Screenshot 2024-03-27 at 10 49 35 AM

@lee-b
Copy link

lee-b commented Mar 30, 2024

This should use a local STT model like whisper and be conversational, rather than 2011-style siri commands.

@kjozwiak kjozwiak mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
browser-ai OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Browser AI
Status: Done
Milestone
1.64.x - Release #2
Development

Successfully merging a pull request may close this issue.

Adds voice recognition for Leo prompts on Android brave/brave-core
5 participants
@kjozwiak @lee-b @SergeyZhukovsky @Uni-verse @brave-builds