Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] Add swap service functionality to parse LiFi swap quotes #37212

Closed
josheleonard opened this issue Mar 29, 2024 · 0 comments · Fixed by brave/brave-core#22652
Closed

[Wallet] Add swap service functionality to parse LiFi swap quotes #37212

josheleonard opened this issue Mar 29, 2024 · 0 comments · Fixed by brave/brave-core#22652
Assignees
@josheleonard
Labels
dev-concern feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude
Milestone
1.67.x - Release

Comments

@josheleonard
Copy link

Description

We want the brave wallet swap service to be able to handle quotes from LiFi so that we can enable the feature in the future.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@josheleonard josheleonard self-assigned this Mar 29, 2024
@josheleonard josheleonard changed the title [Wallet] Add swap service functionality to parse LiFi. swap quotes [Wallet] Add swap service functionality to parse LiFi swap quotes Mar 29, 2024
@josheleonard josheleonard mentioned this issue Mar 29, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 26, 2024
@Douglashdaniel Douglashdaniel mentioned this issue May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
dev-concern feature/web3/wallet/core feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

chore(wallet): prepare swap UI to handle LiFi same-chain swaps brave/brave-core
2 participants
@josheleonard @brave-builds