Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 124 to Chromium 125. #37333

Closed
mkarolin opened this issue Apr 4, 2024 · 8 comments · Fixed by brave/brave-core#22936
Closed

Upgrade from Chromium 124 to Chromium 125. #37333

mkarolin opened this issue Apr 4, 2024 · 8 comments · Fixed by brave/brave-core#22936
Assignees
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA/No QA Pass - Android ARM QA Pass - Android Tab QA Pass - iPhone QA Pass-Win64 QA/Test-Plan-Specified release-notes/exclude

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Apr 4, 2024

Upgrade from Chromium 124 to Chromium 125

https://chromium.googlesource.com/chromium/src/+log/124.0.6367.29...125.0.6382.3/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

  • Brave Wallet: Solana functionality
  • All "panels" show up correctly (VPN, Wallet, Rewards, Tipping, Shields)
  • Web Discovery infobar shows up correctly
  • In DevTools, navigator.brave.isBrave() returns correct value (true in a Promise)
  • VPN installation on Windows works
  • Side panel UI functions as expected
  • Hamburger -> History -> Recent tabs showing correctly
  • Brave wallet can import legacy wallet
  • General Sync functionality
  • Shields: cookies control works correctly

iOS Affected areas:

  • Sync works

Android Affected areas:

  • URL bar UI (make sure its look doesn't change)
  • Tab overview UI (make sure its look doesn't change)
  • NTP layout (double check there is no UI regression)
  • brave://version (double check apk version code has format: 42<minor version (2 digits)><build number (3 digits)><2 more digits>)
  • Sync (double check QR code works)
  • Open YouTube links in Brave (double check this option works as expected)
  • Autoplay option (double check it works as expected)
  • Double check this issue is not reproducible [Follow up to 27572] App crash when searching on normal tab with private tab open #27651
@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop labels Apr 4, 2024
@brave-builds brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels May 3, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 3, 2024
@mkarolin mkarolin added this to the 1.67.x - Nightly milestone May 3, 2024
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 6, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 6, 2024

Verification PASSED on

Brave | 1.67.69 Chromium: 125.0.6422.26 (Official Build) nightly (64-bit)
-- | --
Revision | 3ac44647a57f1d97bd6f702b5c13fd134a352079
OS | Windows 10 Version 22H2 (Build 19045.4291)
All "panels" show up correctly (VPN, Wallet, Rewards, Tipping, Shields)_

Tipping panel:

  • Confirmed that Tipping panel works as expected
  • Confirmed that user can send a tip successfully
  • Confirmed that cross custodian tipping panel is shown as expected
Example Example Example
image image image

Rewards:

  • Confirmed that Rewards panel works as expected
  • Confirmed that publisher info is shown as expected on rewards panel
  • Confirmed that AC notification shown as expected on BR panel
Example Example Example Example
image image image image

Shields

  • Shield panel is shown as expected in normal view
  • Shield panel is shown as expected in advanced view
  • Shield panel is shown as expected disabled mode
Example Example Example
image image image

VPN

  • Confirmed that VPN panel is shown as expected in connected state
  • Confirmed that VPN panel is shown as expected in disconnected state
  • Confirmed that VPN panel is shown as expected in connecting state
  • Confirmed that VPN panel is shown as expected in region selection state
  • Confirmed that VPN panel is shown as expected in error state
Example Example Example Example
image image image image
Web Discovery infobar shows up correctly_PASSED
  • Clean profile 1.67.69 CR 125
  • Open brave://settings/search
  • Confirmed Brave is default search engine in brave://settings/search
  • Enter a string "hello" in the URL bar
  • Confirmed that Web discovery info bar is shown
  • Confirmed that the Web discovery info bar looks correct and all the links/buttons on the info bar works as expected

image

In DevTools, navigator.brave.isBrave() returns correct value (true in a Promise)_PASSED

image

VPN installation on Windows works_PASSED
  • Confirmed that user can connect to VPN without any issues
  • Confirmed that user can change the VPN region without any issues
  • Confirmed that user can disconnect and reconnect VPN

Install and connect VPN:

Example Example Example
image image image

Change the region:

Example Example Example
image image image

Disconnect/reconnect VPN:

Example Example
image image
Side panel UI functions as expected_PASSED
Hamburger -> History -> Recent tabs showing correctly_PASSED
  1. Confirmed that user can see recent tabs listed under the brave://history
  2. Confirmed that date and time is shown correctly for the recent tabs listed under brave://history
  3. Confirmed that brave://history is not shown on Tor and Private window tabs

image

General Sync functionality_PASSED
  • Verified the sync functionality in general and it works fine without any issues
  • When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices
  • Confirmed the bookmarks syched across all the devices in a sync chain
  • Confirmed that bookmarks added before after the sync chain are syched across all the devices in a sync chain
  • When 2 devices are in a sync chain, remove a device resets the sync chain
  • Confirmed that bookmarks, passwords, extensions, history, open tabs, address, email, phone number synched across all the devices in a sync chain
  • Confirmed that remove a bookmar from device 1 in sync chain removes the bookmark from the other devices in a sync chain
Example Example
image image
Shields: cookies control works correctly_PASSED

Update the cookies setting

  1. Open a site A and and click on the site information icon and ensured that the third party cookies are blocked on the site A
    image
  2. Go to brave://settings/shields and select Block all cookies
  3. Reload the site A and click on the site information icon and ensured that the third party cookies are blocked on the site A
    image
  4. Open the shield panel on site A and ensure that global cookies settings are applied
    image
  5. Go to brave://settings/shields and select Allow all cookies
  6. Reload the site A and click on the site information icon and ensured that the cookies are allowed on the site A
    image
  7. Open the shield panel on site A and ensure that global cookies settings are applied
    image

Check Allow cookies functionality:

  1. Clean profile 1.67.x CR 125
  2. Go to brave://settings/shields
  3. Change cookies settings to Block all cookies
  4. Open a site A
  5. Open shields panel and ensure that block all cookies settings selected in the dropdown
  6. Click on site information on a Site A and ensure that all the cookies are blocked
    image
  7. Go to brave://settings/cookies
  8. Click on Add button and add a Site B to allow cookies list
    image
  9. Open site B in a NTP
  10. Click on site information on a Site B and ensure that all the cookies are allowed as site B is added into allow cookies list in step 8
    image
  11. Open shield panel for site B
  12. Ensured that global cookies settings are applied as expected
    image

Case 1:

  1. Clean profile 1.67.x - CR 125
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block third part cookies to Block all cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are retained

Case 2:

  1. Continuation of case 1
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Block all cookies to Allow all cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are retained

Case 3:

  1. Continuation of case 2
  2. Open a site
  3. Click on the site shield settings
  4. Change the trackers and ad blocking settings from Allow all cookies to Block third party site cookies
  5. Restart the browser
  6. Open the site shield settings, confirmed updated cookies settings are retained

Settings comparison

  1. The Download header is renamed as Download history via brave://settings/ this is an upstream change, confirmed via https://bravesoftware.slack.com/archives/CU5UXM3EC/p1715012663493819?thread_ts=1714686786.766079&cid=CU5UXM3EC
    image
  2. Profile theme and icons are inherited from CR 125- Logged a follow up issue Profile theme colors and icons are inherited from CR125 #38087
    image
  3. Block cookies shield settings dropdown items are changed and it is addressed by the issue follow-up to #36859, Remove redundant Block cookies setting #37305
    image
  4. Third part cookies settings is removed from brave://settings/privacy and it is addressed by the issue follow-up to #36859, Remove redundant Block cookies setting #37305
    image
  5. A new content settings Scrolling & zooming is added via brave://settings/content
    image

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@GeetaSarvadnya
Copy link

@srirambv: Could you verify the following wallet related items on Desktop? Thanks!

  1. Brave Wallet: Solana functionality
  2. Brave wallet can import legacy wallet

@srirambv
Copy link
Contributor

srirambv commented May 6, 2024

Verification passed on

Brave 1.67.69 Chromium: 125.0.6422.26 (Official Build) nightly (64-bit)
Revision 3ac44647a57f1d97bd6f702b5c13fd134a352079
OS Linux
  • Verified Solana functionality works fine
  • Verified all transactions on https://pwgoom.csb.app
  • Verified able to Sign messages
  • Verified legacy transaction works as expected
  • Encountered #38074

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 6, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented May 6, 2024

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.67.69 Chromium: 125.0.6422.26 (Official Build) canary (64-bit) 
Revision	3ac44647a57f1d97bd6f702b5c13fd134a352079
OS	Android 13; Build/TP1A.220624.014; 33; REL
URL bar UI
1.67.58 1.67.69 1.67.69
Screenshot 2024-05-06 at 5 40 41 PM Screenshot 2024-05-06 at 5 43 05 PM Screenshot 2024-05-06 at 3 07 09 PM
Tab overview UI
  • Ensured all options in Tab overview UI are functional and all nothing has regressed.
  • Ensured that Tab overview UI has not changed.
Example Example Example Example
Screenshot 2024-05-06 at 1 07 59 PM Screenshot 2024-05-06 at 1 08 04 PM Screenshot 2024-05-06 at 1 08 18 PM Screenshot 2024-05-06 at 1 09 08 PM
NTP Layout
  • Ensured NTP elements are shown correctly.
  • Ensured disabling each of the options in New Tab Page setting will be reflected in the tab after restart.
Example Example Example
Screenshot 2024-05-06 at 1 21 13 PM Screenshot 2024-05-06 at 1 32 56 PM Screenshot 2024-05-06 at 5 04 41 PM
brave://version
  • Ensured that apk version code has correct format.

Screenshot 2024-05-06 at 1 06 14 PM

Sync (QR code)
  • Ensured joining sync chain is success when using QR code option.
Example Example Example Example
Screenshot 2024-05-06 at 1 09 28 PM Screenshot 2024-05-06 at 1 09 32 PM Screenshot 2024-05-06 at 1 10 00 PM Screenshot 2024-05-06 at 1 10 05 PM
Open YouTube links in Brave
  • Ensured that YouTube links open in Brave when Open YouTube links in Brave setting is enabled (default)
  • Ensured that YouTube links are opened outside of Brave when setting is disabled.

Example | Example
-|-|-
Screenshot 2024-05-06 at 1 17 59 PM | Screenshot 2024-05-06 at 1 18 04 PM

Autoplay option
  • Ensured AutoPlay setting is applied to videos on websites.
  • Ensured that exceptions are working.
Example Example Example
Screenshot 2024-05-07 at 2 08 34 PM Screenshot 2024-05-07 at 2 10 52 PM Screenshot 2024-05-07 at 2 22 02 PM
Check issue #27651)
  • Ensured there are no issues and searches on normal tab with open private tabs.

Screenshot 2024-05-06 at 1 23 08 PM

@Uni-verse
Copy link
Contributor

Uni-verse commented May 7, 2024

Verified on Samsung Galaxy S21 using version:

Brave	1.67.70 Chromium: 125.0.6422.26 (Official Build) canary (64-bit) 
Revision	d50f557a6553f6cbd622cf49c6378712ee4217a8
OS	Android 13; Build/TP1A.220624.014; 33; REL
URL bar UI
Example Example
Screenshot 2024-05-07 at 12 49 10 PM Screenshot 2024-05-07 at 1 56 40 PM
Tab overview UI
  • Ensured all options in Tab overview UI are functional and all nothing has regressed.
  • Ensured that Tab overview UI has not changed.
Example Example Example Example
Screenshot 2024-05-07 at 12 58 06 PM Screenshot 2024-05-07 at 1 52 18 PM Screenshot 2024-05-07 at 1 52 24 PM
NTP Layout
  • Ensured NTP elements are shown correctly.
  • Ensured disabling each of the options in New Tab Page setting will be reflected in the tab after restart.
Example Example Example Example
Screenshot 2024-05-07 at 12 50 48 PM Screenshot 2024-05-07 at 12 50 53 PM Screenshot 2024-05-07 at 12 50 59 PM Screenshot 2024-05-07 at 12 52 01 PM
brave://version
  • Ensured that apk version code has correct format.

Screenshot 2024-05-07 at 1 39 59 PM

Sync (QR code)
  • Ensured joining sync chain is success when using QR code option.
Example Example Example
Screenshot 2024-05-07 at 12 59 20 PM Screenshot 2024-05-07 at 12 59 25 PM Screenshot 2024-05-07 at 1 48 07 PM
Open YouTube links in Brave
  • Ensured that YouTube links open in Brave when Open YouTube links in Brave setting is enabled (default)
  • Ensured that YouTube links are opened outside of Brave when setting is disabled.
Example Example
Screenshot 2024-05-07 at 12 56 11 PM Screenshot 2024-05-07 at 12 56 17 PM
Autoplay option
  • Ensured that Autoplay site setting is enabled by default.
  • Ensured that blocking Autoplay will disabled autoplay for videos on sites.
  • Ensured that adding an allow exception for m.youtube.com will autoplay videos on youtube when blocking is enabled.
Check issue #27651)
  • Ensured there are no issues and searches on normal tab with open private tabs.

Screenshot 2024-05-07 at 1 53 40 PM

@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 17.3.1 using version 1.67.73 (125.0.6422.26)

  • Ensured sync is working with mobile and desktop clients and nothing has regressed.
  • Ensured bookmarks, history, passwords and open tab data is synced when enabled.
  • Ensured creating sync chain from settings as well through segmented tab flow.
  • Ensured deleting sync chain works.
Example Example Example Example
IMG_6082 IMG_6083 IMG_6084 IMG_6085
IMG_6086 IMG_6087 IMG_6088 IMG_6089

@Uni-verse Uni-verse added QA Pass - iPhone OS/iOS Fixes related to iOS browser functionality labels May 7, 2024
@kjozwiak
Copy link
Member

kjozwiak commented May 8, 2024

The above requires 1.66.104 or higher for 1.66.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented May 9, 2024

Labelling as QA/No & release-notes/exclude in favor of #38166 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA/No QA Pass - Android ARM QA Pass - Android Tab QA Pass - iPhone QA Pass-Win64 QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants