Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Do not persist "connect hardware wallet" panel #37402

Closed
josheleonard opened this issue Apr 8, 2024 · 1 comment · Fixed by brave/brave-core#22969
Closed

[Wallet] Do not persist "connect hardware wallet" panel #37402

josheleonard opened this issue Apr 8, 2024 · 1 comment · Fixed by brave/brave-core#22969

Comments

@josheleonard
Copy link

Description

We should not persist navigation to this panel, as it causes bugs when signing transactions and messages.

Steps to Reproduce

  1. Go to https://pwgoom.csb.app/
  2. connect with a hardware wallet
  3. click "sign transaction"
  4. click "sign"
  5. the connect hardware panel should open
  6. close the panel
  7. reopen the panel

Actual result:

connect hardware panel should be shown

Expected result:

The initial "sign transaction" screen should be shown

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.66.95 Chromium: 124.0.6367.91 (Official Build) beta (64-bit)
Revision e1f8e3c95a12986231bc8226b78a951233e7c026
OS Windows 11 Version 23H2 (Build 22631.3527)
  • Verified steps from brave/brave-core#22969
  • Verified sign transaction request is initialized every time panel is closed and reopened
  • Verified for both Wallet and Hardware wallet
22969.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants