Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Font Subpage #37555

Closed
jonathansampson opened this issue Apr 12, 2024 · 2 comments · Fixed by brave/brave-core#23064
Closed

Missing Font Subpage #37555

jonathansampson opened this issue Apr 12, 2024 · 2 comments · Fixed by brave/brave-core#23064

Comments

@jonathansampson
Copy link
Contributor

Description

Font-related setting sub page is not present, causing page to flash briefly then error.

Steps to Reproduce

Open Settings and search for Fonts, or attempt direct-navigation to brave://settings/fonts?search=fonts

Actual result:

Recording.2024-04-12.150105.mp4

Expected result:

Subpage is visible and interactive

Reproduces how often:

Easily

Brave version (brave://version info)

1.67.6 Chromium: 124.0.6367.29 (Official Build) nightly (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? Yes
@kjozwiak
Copy link
Member

The above requires 1.65.113 or higher for 1.65.x verification 👍

@stephendonner
Copy link

stephendonner commented Apr 16, 2024

Verified PASSED using

Brave | 1.65.113 Chromium: 124.0.6367.60 (Official Build) (64-bit)
-- | --
Revision | c1a6c6e73c1f2f1e5bf00a6f0d42065219845887
OS | Windows 10 Version 22H2 (Build 19045.4291)

Steps:

  1. installed 1.65.113
  2. launched Brave
  3. opened brave://settings/fonts?search=fonts
  4. confirmed Settings page rendered without flickering/disappearing

Confirmed Settings page rendered, without font-specific errors in the JavaScript console

example example
image image

@rebron rebron removed this from Completed in Settings Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment