Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] New Tab Takeover video ad design fixes #37653

Closed
4 tasks done
aseren opened this issue Apr 17, 2024 · 2 comments · Fixed by brave/brave-core#23149
Closed
4 tasks done

[ads] New Tab Takeover video ad design fixes #37653

aseren opened this issue Apr 17, 2024 · 2 comments · Fixed by brave/brave-core#23149
Assignees
Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-iPad QA Pass-iPhone QA/Yes release-notes/exclude
Projects
Milestone

Comments

@aseren
Copy link
Collaborator

aseren commented Apr 17, 2024

  • Change size of NTT video ad play button to fit the design
  • Change gradient to be on top of the NTT video ad
  • If a user exits full screen, the video should return to the keyframe in the background
  • After the video plays in full, the video should return to the keyframe in the background
@aseren aseren added bug feature/ads OS/iOS Fixes related to iOS browser functionality labels Apr 17, 2024
@aseren aseren changed the title [ads] Change size of NTT video ad play button to fit the design [ads] New Tab Takeover video ad design fixes Apr 17, 2024
@aseren aseren self-assigned this Apr 17, 2024
@aseren aseren added this to In progress in Ads Apr 17, 2024
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Apr 17, 2024
@tmancey tmancey moved this from In progress to Review in Ads Apr 18, 2024
Ads automation moved this from Review to Done Apr 23, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 23, 2024
@LaurenWags
Copy link
Member

Requires 1.66.95 or higher to test

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 30, 2024
@hffvld
Copy link
Collaborator

hffvld commented Apr 30, 2024

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.5
- iPad Air / iPadOS 16.7.2
Brave build: 1.66 (95)
BraveCore: 1.66.95 (124.0.6367.91)

STEPS:

  1. Follow the steps from [ads] New Tab Takeover video ads design fixes brave-core#23149 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that NTT video ad autoplay is started when NTP with New Tab Takeover video ad is opened
  • Verified that the Play button becomes visible when the NTT video ad autoplay is finished
  • Verified that stop keyframe is shown after NTT video playback is finished (The stop keyframe is the frame where autoplay finishes)
  • Verified that stop keyframe is shown after the user cancels the playback (The stop keyframe is the frame where autoplay finishes)

iPhone

2024-04-30_10-16-38.mp4

iPad

2024-04-30_10-39-51.mp4

@hffvld hffvld added QA Pass-iPhone QA Pass-iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/ads OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-iPad QA Pass-iPhone QA/Yes release-notes/exclude
Projects
Ads
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants