Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel button do not have border in the Report a broken site #38098

Open
MadhaviSeelam opened this issue May 6, 2024 · 1 comment
Open

Cancel button do not have border in the Report a broken site #38098

MadhaviSeelam opened this issue May 6, 2024 · 1 comment
Labels
bug design A design change, especially one which needs input from the design team OS/Desktop QA/Test-Plan-Specified QA/Yes

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented May 6, 2024

Description

Found while testing #37970. Report broken site do not have border for Cancel button as with the others such as Clear browsing data

Steps to Reproduce

  1. Install 1.67.64
  2. launch Brave
  3. navigate to a website (eg. cnn.com)
  4. click hamburger >> Help >> Report a broken site

Actual result:

Cancel button do not have border in the Report a broke site

image

Expected result:

Similar to Clear browsing data modal
image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.67.64 Chromium: 125.0.6422.26 (Official Build) nightly (64-bit)
-- | --
Revision | bfd2636e5cf7bb0b023414637e9a803310544b77
OS | Windows 11 Version 23H2 (Build 22631.3527)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @aguscruiz

cc: @brave/qa-team

@MadhaviSeelam MadhaviSeelam added bug design A design change, especially one which needs input from the design team QA/Yes QA/Test-Plan-Specified OS/Desktop labels May 6, 2024
@MadhaviSeelam MadhaviSeelam changed the title Cancel button do not have border in the Report a broke site Cancel button do not have border in the Report a broken site May 6, 2024
@aguscruiz
Copy link

Correct one for cancel is the gray button without outline. That applies to all cancel buttons, we shouldn't use the outlined version on them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team OS/Desktop QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants