Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update button colors and style to the latest Nala design sytem #37970

Closed
rebron opened this issue Apr 30, 2024 · 5 comments · Fixed by brave/brave-core#23365
Closed

Update button colors and style to the latest Nala design sytem #37970

rebron opened this issue Apr 30, 2024 · 5 comments · Fixed by brave/brave-core#23365
Assignees
Labels
design A design change, especially one which needs input from the design team OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 30, 2024

Description

Several buttons are still using the old Brave orange colors. These should be the "blurple" color per the Nala design system.

Actual result:

Bookmarks dialog
Screenshot 2024-04-29 at 5 47 01 PM

Views MdButton
image_360

Infobar
image

Webcompat report (maybe it's WebUI)
image

task manager
image

Expected result:

Screenshot 2024-04-30 at 3 57 29 PM

Reproduces how often:

Easily

Brave version (brave://version info)

Target 1.66.x for fix.

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a Orange buttons
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added polish Nice to have — usually related to front-end/visual tasks design A design change, especially one which needs input from the design team OS/Desktop labels Apr 30, 2024
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include labels Apr 30, 2024
@simonhong
Copy link
Member

working on this.

simonhong added a commit to brave/brave-core that referenced this issue May 1, 2024
simonhong added a commit to brave/brave-core that referenced this issue May 2, 2024
simonhong added a commit to brave/brave-core that referenced this issue May 2, 2024
simonhong added a commit to brave/brave-core that referenced this issue May 2, 2024
simonhong added a commit to brave/brave-core that referenced this issue May 2, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 2, 2024
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 3, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 3, 2024

Verification PASSED using

Brave | 1.67.64 Chromium: 124.0.6367.118 (Official Build) nightly (64-bit)
-- | --
Revision | 53ddfd8ce864582b576ac5c24a189fa392e53b59
OS | Windows 11 Version 23H2 (Build 22631.3527)

Close tabs - PASSED

1.67.x 1.65.x
image image

Infobar - PASSED

1.67.x 1.65.x
image image

Bookmarks dialog - PASSED

1.67.x 1.65.x
image image
image image

Report broken site - FAILED

1.67.x 1.65.x
image image

Save Password - PASSED

example example
image image
image image
image image
image image
image image

Tune icon - PASSED

1.67.x 1.65.x
image image

Playlist - PASSED

1.67.x 1.65.x
image image
image image

Install app - PASSED

1.67.x 1.65.x
image image

Extensions - PASSED

example example example example example
image image image image image

Sidebar

Leo - PASSED

example example example
image image image

VPN - Failed

1.67.x 1.65.x
image image
image image
image image

Task Manager - PASSED

1.67.x 1.65.x
image image

Widevine - PASSED

1.67.x 1.65.x
image image

On-device site data - PASSED

1.67.x 1.65.x
image image

Site permissions - PASSED

1.67.x 1.65.x
image
image

@kjozwiak
Copy link
Member

kjozwiak commented May 6, 2024

@MadhaviSeelam please let me know once you're done the above as we have an uplift into 1.66.x via brave/brave-core#23405. However, looks like there's a few cases that are failing so we might want to get those fixed before uplifting. CCing @rebron on thoughts.

@kjozwiak
Copy link
Member

kjozwiak commented May 6, 2024

The above requires 1.66.102 or higher for 1.66.x verification 👍 @brave/qa-team keep in mind that @MadhaviSeelam found several issues relating to buttons/labels as per:

Please keep an eye on any other buttons/labels that might still appear is orange which should be set as blurple. Removing the QA/Pass label as we'll need to re-verify the above using 1.66.x. Used #37970 (comment) as the needed verification to get the above uplifted into 1.66.x.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 7, 2024
@LaurenWags
Copy link
Member

LaurenWags commented May 7, 2024

Verified with

Brave | 1.66.102 Chromium: 124.0.6367.118 (Official Build) beta (x86_64)
-- | --
Revision | 3f00a25afc25dfd9a221c0d98c0ab3ed93ab47ee
OS | macOS Version 13.6.6 (Build 22G630)

Close tabs - PASSED

1.66.x 1.65.x
Screenshot 2024-05-07 at 11 18 06 AM Screenshot 2024-05-07 at 11 18 53 AM

Bookmarks bar - PASSED

1.66.x 1.65.x
Screenshot 2024-05-07 at 11 27 14 AM Screenshot 2024-05-07 at 11 27 19 AM

Infobar - PASSED

1.66.x 1.65.x
Screenshot 2024-05-07 at 11 27 00 AM Screenshot 2024-05-07 at 11 27 05 AM

Bookmarks dialog - PASSED

1.66.x 1.65.x
Screenshot 2024-05-07 at 11 54 02 AM Screenshot 2024-05-07 at 11 54 25 AM
Screenshot 2024-05-07 at 11 54 12 AM Screenshot 2024-05-07 at 11 54 41 AM

Report broken site - Failed - see follow up issue below

1.66.x 1.65.x
Screenshot 2024-05-07 at 11 58 16 AM Screenshot 2024-05-07 at 11 58 29 AM

Save Password - PASSED

1.66.x 1.65.x
Screenshot 2024-05-07 at 12 21 08 PM Screenshot 2024-05-07 at 12 23 21 PM
Screenshot 2024-05-07 at 12 21 45 PM Screenshot 2024-05-07 at 12 23 35 PM
Screenshot 2024-05-07 at 12 22 31 PM Screenshot 2024-05-07 at 12 24 12 PM
Screenshot 2024-05-07 at 12 22 11 PM Screenshot 2024-05-07 at 12 24 19 PM
Screenshot 2024-05-07 at 12 22 39 PM Screenshot 2024-05-07 at 12 24 26 PM

Tune icon - PASSED

1.66.x 1.65.x
Screenshot 2024-05-08 at 2 41 45 PM Screenshot 2024-05-08 at 2 42 15 PM
Screenshot 2024-05-08 at 2 41 58 PM Screenshot 2024-05-08 at 2 42 26 PM

Install app - PASSED with follow up issue

1.66.x 1.65.x
Screenshot 2024-05-08 at 2 45 47 PM Screenshot 2024-05-08 at 2 45 52 PM
Screenshot 2024-05-08 at 2 45 59 PM Screenshot 2024-05-08 at 2 46 06 PM
Screenshot 2024-05-08 at 2 46 13 PM Screenshot 2024-05-08 at 2 46 19 PM

Extensions - PASSED with follow up issue

1.66.x 1.65.x
Screenshot 2024-05-08 at 3 11 55 PM Screenshot 2024-05-08 at 3 12 00 PM
Screenshot 2024-05-08 at 3 12 24 PM Screenshot 2024-05-08 at 3 12 29 PM
Screenshot 2024-05-08 at 3 13 00 PM Screenshot 2024-05-08 at 3 13 29 PM
Screenshot 2024-05-08 at 3 13 05 PM Screenshot 2024-05-08 at 3 13 34 PM
Screenshot 2024-05-08 at 3 27 55 PM Screenshot 2024-05-08 at 3 28 00 PM

Leo - PASSED

1.66.x 1.65.x
Screenshot 2024-05-08 at 4 11 19 PM Screenshot 2024-05-08 at 4 11 40 PM
Screenshot 2024-05-08 at 4 11 54 PM Screenshot 2024-05-08 at 4 12 01 PM

VPN - Failed - see follow up issue below

1.66.x 1.65.x
Screenshot 2024-05-09 at 8 40 48 AM Screenshot 2024-05-09 at 8 47 35 AM
Screenshot 2024-05-09 at 8 50 09 AM Screenshot 2024-05-09 at 8 50 35 AM
Screenshot 2024-05-09 at 8 50 17 AM Screenshot 2024-05-09 at 8 50 42 AM

Task Manager - PASSED

  • note, uses OS settings/coloring
1.66.x 1.65.x
Screenshot 2024-05-09 at 8 59 45 AM Screenshot 2024-05-09 at 9 00 15 AM

Widevine - PASSED with follow up issue

1.66.x 1.65.x
Screenshot 2024-05-09 at 9 09 04 AM Screenshot 2024-05-09 at 9 09 53 AM
Screenshot 2024-05-09 at 9 09 09 AM Screenshot 2024-05-09 at 9 09 59 AM

On Device Site Data - PASSED

1.66.x 1.65.x
Screenshot 2024-05-08 at 2 41 58 PM Screenshot 2024-05-08 at 2 42 26 PM

Site permissions - PASSED with follow up issue

1.66.x 1.65.x
Screenshot 2024-05-09 at 9 22 33 AM Screenshot 2024-05-09 at 9 22 57 AM
Screenshot 2024-05-09 at 9 22 38 AM Screenshot 2024-05-09 at 9 23 02 AM

@rebron rebron changed the title Update button coloring/style to Nala Update button colors and style to the latest Nala design sytem May 8, 2024
@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants