Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force-update components that only wants to be installed at launch #38119

Open
goodov opened this issue May 7, 2024 · 0 comments · May be fixed by brave/brave-core#23453
Open

Don't force-update components that only wants to be installed at launch #38119

goodov opened this issue May 7, 2024 · 0 comments · May be fixed by brave/brave-core#23453
Assignees

Comments

@goodov
Copy link
Member

goodov commented May 7, 2024

Most components don't need to be force-updated at each launch, but we do this, because it's the only way to force-install a component if it's absent.

The Chromium-way is to register a component at browser launch and then wait for it to be installed or updated after 1 minute.

We want to support forced updates for AdBlock components at the very start, this is already implemented via OnDemandUpdate method, but for other components we only want to force-install them if they are absent. To do this we can implement OnDemandInstall method that will only force-install the component, but not update it at launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant