Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in OnboardingViewModel #38224

Closed
SergeyZhukovsky opened this issue May 10, 2024 · 0 comments · Fixed by brave/brave-core#23641
Closed

Crash in OnboardingViewModel #38224

SergeyZhukovsky opened this issue May 10, 2024 · 0 comments · Fixed by brave/brave-core#23641
Assignees
Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash in Google Play Console on nightly 1.68.2. We should uplift it to other channels if we have that code path there.

Exception : java.lang.IllegalStateException	Wallet password must not be null.
  at org.chromium.base.JniAndroid$UncaughtExceptionException.<init> (JniAndroid.java:49)
  at org.chromium.base.JniAndroid.handleException (JniAndroid.java:89)
  at android.os.MessageQueue.nativePollOnce
  at android.os.MessageQueue.next (MessageQueue.java:339)
  at android.os.Looper.loopOnce (Looper.java:176)
  at android.os.Looper.loop (Looper.java:328)
  at android.app.ActivityThread.main (ActivityThread.java:9220)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:586)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1099)
Caused by java.lang.IllegalStateException:
  at org.chromium.chrome.browser.crypto_wallet.model.OnboardingViewModel.getPassword (OnboardingViewModel.java:30)
  at org.chromium.chrome.browser.crypto_wallet.fragments.onboarding.OnboardingCreatingWalletFragment.createWallet (OnboardingCreatingWalletFragment.java:76)
  at org.chromium.chrome.browser.crypto_wallet.fragments.onboarding.OnboardingCreatingWalletFragment.lambda$onResume$1 (OnboardingCreatingWalletFragment.java:63)
  at org.chromium.brave_wallet.mojom.KeyringService_Internal$KeyringServiceIsWalletCreatedResponseParamsForwardToCallback.accept (KeyringService_Internal.java:1345)
  at org.chromium.mojo.bindings.RouterImpl.handleIncomingMessage (RouterImpl.java:222)
  at org.chromium.mojo.bindings.RouterImpl$HandleIncomingMessageThunk.accept (RouterImpl.java:29)
  at org.chromium.mojo.bindings.Connector.readAndDispatchMessage (Connector.java:194)
  at org.chromium.mojo.bindings.Connector.readOutstandingMessages (Connector.java:159)
  at org.chromium.mojo.bindings.Connector.onWatcherResult (Connector.java:137)
  at org.chromium.mojo.bindings.Connector$WatcherCallback.onResult (Connector.java:128)
  at org.chromium.mojo.system.impl.WatcherImpl.onHandleReady (WatcherImpl.java:60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants