Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: History page pre-load UI is not consistent with post-load UI #3826

Closed
petemill opened this issue Mar 21, 2019 · 1 comment · Fixed by brave/brave-core#1909
Closed

Comments

@petemill
Copy link
Member

petemill commented Mar 21, 2019

Since we've changed the look of the top toolbar area of WebUI pages, the layout of the pre-load top area of pages is inconsistant. This is especially noticeable on the History page, since it contains the page title in the incorrect coords:

image

image

Test plan

  1. Visit brave://history

Actual

The page title is displayed in the top left (in English it's 'History')

Expected

No page title is displayed before the Navigation Bar loads

@LaurenWags
Copy link
Member

LaurenWags commented May 21, 2019

Verified passed with

Brave 0.65.98 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment