DumpWithoutCrashing in NavigationRequest::OnNavigationEventProcessed

[iefremov]

https://share.backtrace.io/api/share/eTUp1UyjYACjYx1H0bzuj11

[ 00 ] crash_reporter::DumpWithoutCrashing() ( crashpad_android.cc:655 )
[ 01 ] base::debug::DumpWithoutCrashing(base::Location const&, base::TimeDelta) ( dump_without_crashing.cc:108 )
[ 02 ] logging::(anonymous namespace)::DumpWithoutCrashing(base::debug::CrashKeyString*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::Location const&, base::NotFatalUntil) ( check.cc:131 )
[ 03 ] logging::(anonymous namespace)::NotReachedLogMessage::~NotReachedLogMessage() ( check.cc:144 )
[ 04 ] logging::(anonymous namespace)::NotReachedLogMessage::~NotReachedLogMessage() ( check.cc:142 )
[ 05 ] logging::CheckError::~CheckError() ( unique_ptr.h:68 )
[ 06 ] content::NavigationRequest::OnNavigationEventProcessed(content::NavigationThrottleRunner::Event, content::NavigationThrottle::ThrottleCheckResult) ( navigation_request.cc:6969 )
[ 07 ] content::NavigationThrottleRunner::InformDelegate(content::NavigationThrottle::ThrottleCheckResult const&) ( navigation_throttle_runner.cc:381 )
[ 08 ] content::NavigationThrottleRunner::ProcessInternal() ( navigation_throttle_runner.cc:356 )
[ 09 ] content::NavigationThrottleRunner::ResumeProcessingNavigationEvent(content::NavigationThrottle*) ( navigation_throttle_runner.cc:143 )
[ 10 ] content::NavigationRequest::Resume(content::NavigationThrottle*) ( navigation_request.cc:7143 )
[ 11 ] brave_shields::DomainBlockNavigationThrottle::OnShouldBlockDomain(std::__Cr::pair<bool, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>) ( domain_block_navigation_throttle.cc:0 )
[ 12 ] base::internal::Invoker<base::internal::FunctorTraits<void (brave_shields::DomainBlockNavigationThrottle::*&&)(std::__Cr::pair<bool, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>), base::WeakPtr<brave_shields::DomainBlockNavigationThrottle>&&>, base::internal::BindState<true, true, false, void (brave_shields::DomainBlockNavigationThrottle::*)(std::__Cr::pair<bool, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>), base::WeakPtr<brave_shields::DomainBlockNavigationThrottle>>, void (std::__Cr::pair<bool, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>)>::RunOnce(base::internal::BindStateBase*, std::__Cr::pair<bool, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>&&) ( bind_internal.h:738 )

[SergeyZhukovsky]

It's just a guess, but it looks like there are cases that we shouldn't call Resume() when we defer navigation. That happens on redirects. Upstream has a logic of handling that in platform_auth_navigation_throttle.cc or safe_sites_navigation_throttle.cc. I'm going to apply the same logic to our throttle and take a look on how does it perform.

[SergeyZhukovsky]

We still see that issue, reopening it.