Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack build output should be the same for different build configurations #38437

Closed
petemill opened this issue May 21, 2024 · 0 comments · Fixed by brave/brave-core#23753
Closed
Assignees
Labels
dev-concern OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude

Comments

@petemill
Copy link
Member

petemill commented May 21, 2024

Webpack references from different architectures' output directories (e.g. Release and Release_arm64) creates different output file names. File names are based on a generated hash / ID of all the paths. This can be observed by comparing file names in e.g. gen/brave/components/web-ui-brave_new_tab/.

See tracking issue at #38435 for more details.

Test plan

One symptom of the webpack build having different filenames on intel vs arm is the NTP producing errors when loading some files (e.g. JS chunks) and so far they have been predictable:

  1. Open the universal .app on an intel mac
  2. Visit NTP
  3. Click Customize
  4. Switch to "Top Sites"
  5. NTP goes blank due to JS error

-or-

  1. Open the universal .app on an intel mac
  2. In chrome://flags enable "Brave Search on NTP"
  3. Restart browser
  4. Visit NTP
  5. NTP goes blank due to JS error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
2 participants