Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always display Show Zero Balances button in Select a Token to Send #38452

Closed
3 of 5 tasks
StephenHeaps opened this issue May 21, 2024 · 0 comments · Fixed by brave/brave-core#23831
Closed
3 of 5 tasks

Always display Show Zero Balances button in Select a Token to Send #38452

StephenHeaps opened this issue May 21, 2024 · 0 comments · Fixed by brave/brave-core#23831
Assignees
@StephenHeaps
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/include
Milestone
1.68.x - Beta

Comments

@StephenHeaps
Copy link

StephenHeaps commented May 21, 2024 •
edited
Loading

Description

Currently the button is only displayed when 0 tokens (with balance) are shown. We could keep the the logic to

Steps to reproduce

  1. Use wallet with 0 balance on some account and/or some network
  2. Open Send
  3. In Select a Token to Send modal, Show Zero Balances button is not displayed
  4. If tokens displayed, filter to network without any balance on any account
  5. Show Zero Balances button is displayed

Actual result

Show Zero Balances button is not displayed

Expected result

Always show Show Zero Balances button, but continue hiding zero balance accounts/tokens by default.

ex:

Reproduces how often

Easily reproduced

Brave version

Release, Beta, Nightly

Device/iOS version

iOS 17

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

Slight frontend UX improvement for #38451
@StephenHeaps StephenHeaps added OS/iOS Fixes related to iOS browser functionality feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes labels May 21, 2024
@StephenHeaps StephenHeaps self-assigned this May 24, 2024
@StephenHeaps StephenHeaps mentioned this issue May 24, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenHeaps StephenHeaps

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.68.x - Beta
Development

Successfully merging a pull request may close this issue.

fix(wallet): Always display 'Show Zero Balances' button in Send on iOS brave/brave-core
2 participants
@StephenHeaps @brave-builds