Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C125] Leo suggestion doesn't have rounded corners #38516

Closed
3 of 6 tasks
samartnik opened this issue May 23, 2024 · 2 comments · Fixed by brave/brave-core#23810
Closed
3 of 6 tasks

[C125] Leo suggestion doesn't have rounded corners #38516

samartnik opened this issue May 23, 2024 · 2 comments · Fixed by brave/brave-core#23810
Assignees
@samartnik
Labels
browser-ai bug feature/url-bar OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes regression release-notes/include
Milestone
1.66.x - Release #4

Comments

@samartnik
Copy link
Contributor

Description

Due to upstream changes in C125 chromium/chromium@d1b49f4

Screenshot_20240523-094738

Steps to reproduce

  1. Tap in url bar
  2. Leo suggestion shape is rectangular

Actual result

Leo suggestion shape is rectangular

Expected result

Leo suggestion shape match other items (with rounded corners)

Reproduces how often

Easily reproduced

Brave version

1.68.x

Device

  • Brand/model: any
  • Android version: any

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label May 23, 2024
@samartnik samartnik self-assigned this May 23, 2024
@samartnik samartnik mentioned this issue May 23, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 23, 2024
This was referenced May 23, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.66.115 or higher for 1.66.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented May 24, 2024 •
edited
Loading

Verified on Samsung Galaxy S21 using version:

Brave	1.66.115 Chromium: 125.0.6422.112 (Official Build) (64-bit) 
Revision	a168513c9c84b6ba793d5eac01c725982187aeb4
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Ensured that Leo suggestion box in search has rounded corners.
  • Ensured tapping on Leo suggestion in search box will launch Leo chat.
Example Example
Screenshot 2024-05-24 at 12 01 25 PM Screenshot 2024-05-24 at 12 31 51 PM

@kjozwiak kjozwiak mentioned this issue May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
browser-ai bug feature/url-bar OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes regression release-notes/include
Projects
None yet
Milestone
1.66.x - Release #4
Development

Successfully merging a pull request may close this issue.

[Android] Fix for Leo suggestion shape brave/brave-core
4 participants
@kjozwiak @Uni-verse @samartnik @brave-builds