Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cr126] Omnibox overlaps on the first Brave launch #38524

Closed
1 of 6 tasks
hffvld opened this issue May 23, 2024 · 1 comment
Closed
1 of 6 tasks

[Cr126] Omnibox overlaps on the first Brave launch #38524

hffvld opened this issue May 23, 2024 · 1 comment
Assignees
@AlexeyBarabash
Labels
bug Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality QA/Yes regression

Comments

@hffvld
Copy link
Contributor

hffvld commented May 23, 2024 •
edited
Loading

Description

Omnibox overlaps on the first Brave launch. The issue is not seen after Brave restart.

Steps to reproduce

  1. Fresh install and launch Brave 1.68.38 with Cr126
  2. Go through the onboarding
  3. Land on NTP > Observe

Actual result

Omnibox overlaps on the first Brave launch. The issue is not seen after Brave restart.

1 2
1 2
timestamp_11-03-31_11-03-58.mp4

Expected result

Omnibox must not be overlapped.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.68.38
Chromium: 126.0.6478.17 (Official Build) canary (64-bit)

Device

  • Brand/Model: Google Pixel 6
  • Android version: oriole-user 14 AP1A.240505.004 release-keys

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@hffvld hffvld added bug QA/Yes regression OS/Android Fixes related to Android browser functionality Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) labels May 23, 2024
@hffvld hffvld mentioned this issue May 23, 2024
Closed
25 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue May 23, 2024
@AlexeyBarabash
CachedFlag now has two different ctors
5c3d0b7 
fixes brave/brave-browser#38524

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d185bd9ea3aa006e8dfc789dce07f3d902886c9a

[Android] Allow CachedFlags to specify test defaults

	This mimics fieldtrial_testing_config.json for CachedFlag in tests.
	It does not affect the flag value in developer builds like
	fieldtrial_testing_config.json does, however.

	Bug: 40239922
	Change-Id: I8b67a6c2feeadd5ce12dcf6d41fe4c2e3e3d240f
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523173
@AlexeyBarabash
Copy link
Contributor

this is fixed at brave/brave-core@5c3d0b7

cdesouza-chromium pushed a commit to brave/brave-core that referenced this issue May 24, 2024
@AlexeyBarabash @cdesouza-chromium
CachedFlag now has two different ctors
cb2d0ff 
fixes brave/brave-browser#38524

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d185bd9ea3aa006e8dfc789dce07f3d902886c9a

[Android] Allow CachedFlags to specify test defaults

	This mimics fieldtrial_testing_config.json for CachedFlag in tests.
	It does not affect the flag value in developer builds like
	fieldtrial_testing_config.json does, however.

	Bug: 40239922
	Change-Id: I8b67a6c2feeadd5ce12dcf6d41fe4c2e3e3d240f
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
bug Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Android Fixes related to Android browser functionality QA/Yes regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexeyBarabash @hffvld