Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Allow hiding un-owned NFTs in portfolio #38549

Closed
3 of 6 tasks
josheleonard opened this issue May 24, 2024 · 1 comment · Fixed by brave/brave-core#23816
Closed
3 of 6 tasks

[Wallet] Allow hiding un-owned NFTs in portfolio #38549

josheleonard opened this issue May 24, 2024 · 1 comment · Fixed by brave/brave-core#23816

Comments

@josheleonard
Copy link

Description

We should add a toggle to enable/disable showing NFTs that are not owned by any wallet account
Screenshot 2024-05-24 at 8 16 03 AM

Steps to reproduce

  1. create a wallet
  2. add an NFT that is owned by one of your accounts
  3. import an NFT that is not owned by any of your accounts
  4. view the portfolio NFTs tab
  5. open the filters modal

Actual result

There is no option to hide unowned NFTs; The unowned NFTs will always be displayed

Expected result

There should be an option to hide unowned NFTs; The unowned NFTs will be displayed only if the option is set to not hide unowned NFTs

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.66.113 Chromium: 125.0.6422.76 (Official Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@srirambv
Copy link
Contributor

Verified as part of #38547 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants