Disabling Close window when closing last tab breaks Bring all tabs to this window functionality.

[ghost]

Description

When you disable Close window when closing last tab (brave://settings/system) and try to use Bring all tabs to this window, the functionality of bringing new tabs will work, but it will not close those tabs even if they are not the last tab in the last window for the window to stay opened.

This means since it will leave windows with a new tab behind instead of closing them normally because they are not the last tab you will end up with many windows opened, and you have to close them all manually anyway.

I recorded a video showing the issue, and how the expected behavior should be just like when I closed the window manually, because there is no 'last tab' yet, so the problem with how Bring all tabs to this window is doing stuff on the background to bring the tabs which messed with the whole other feature, so those two features are conflicting even if technically they shouldn't.

Steps to reproduce

1. go to brave://settings/system and make sure Close window when closing last tab is disabled
2. create a new window and right click any tab to use Bring all tabs to this window button.
3. the other window doesn't get closed and leaves a normal new tab behind.

Actual result

Recording.2024-06-03.201416.mp4

Expected result

• All windows but the one where Bring all tabs to this window is used gets closed.
• No windows with new tabs left behind.
• Window doesn't get closed only when it is really the real very last one.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.70 Chromium: 126.0.6478.26 (Official Build) nightly (64-bit)
Windows 11 Version 23H2 (Build 22631.3672)

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

No response

[ghost]

@sangwoo108 I didn't know you also implemented Bring all tabs to this window so I will tag you, so you know about this misbehavior.
As usual you not anybody got assigned, tagged or anything to do something about real issues. So I guess I am forced to tag you to force these types of issues to actually get somewhere, I wish I didn't have to.

Thank you for caring about my reports, Have a nice day!

[sangwoo108]

Thank you for reporting! Let me take a look