Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Ads should be shutdown if the wallet is invalid for a Brave Rewards user #38818

Closed
tmancey opened this issue Jun 5, 2024 · 2 comments · Fixed by brave/brave-core#24009
Closed

[ads] Ads should be shutdown if the wallet is invalid for a Brave Rewards user #38818

tmancey opened this issue Jun 5, 2024 · 2 comments · Fixed by brave/brave-core#24009
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Milestone
1.68.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 5, 2024 •
edited
Loading

Previously, we only initiated a shutdown if the user had opted into notification ads and the wallet was invalid. A wallet is required for any type of ad if a user has joined Rewards.
@tmancey tmancey added bug priority/P3 The next thing for us to work on. It'll ride the trains. dev-concern QA/Yes release-notes/exclude feature/ads labels Jun 5, 2024
@tmancey tmancey self-assigned this Jun 5, 2024
@tmancey tmancey added this to Review in Ads Jun 5, 2024
@tmancey tmancey mentioned this issue Jun 5, 2024
Merged
24 tasks
@tmancey tmancey added OS/Desktop OS/Android Fixes related to Android browser functionality and removed dev-concern labels Jun 5, 2024
Ads automation moved this from Review to Done Jun 5, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone Jun 5, 2024
@btlechowski
Copy link

Verified with

Brave 1.68.94 Chromium: 126.0.6478.114 (Official Build) beta (64-bit)
Revision 8981faf58380240eab6e999e6bf06f9ed9314336
OS Linux

Verified ads are not initialized when recovery seed is corrupted

[2863:2863:0622/142501.136891:VERBOSE1:ads_service_impl.cc(463)] Failed to initialize Brave Rewards wallet

@btlechowski btlechowski added QA Pass-Linux and removed OS/Android Fixes related to Android browser functionality labels Jun 22, 2024
@btlechowski
Copy link

Removed OS/Android as it is not possible to corrupt seed on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Status: Done
Ads
  
Done
Milestone
1.68.x - Release
3 participants
@tmancey @btlechowski @brave-builds