Safety Check is warning about Passwords even though we disable that feature #39212
Closed
1 of 6 tasks
Labels
feature/password-manager
needs-text-change
This change requires some careful wording.
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Win64
QA/Yes
release-notes/include
Projects
Milestone
Description
As reported in #12859 (comment), there is a very unhelpful message from Safety Check in
![Screenshot from 2024-06-20 16-54-33](https://private-user-images.githubusercontent.com/167821/341595798-56c37762-ab53-4d0d-86a3-43215a69af92.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE5NDAwOTEsIm5iZiI6MTcyMTkzOTc5MSwicGF0aCI6Ii8xNjc4MjEvMzQxNTk1Nzk4LTU2YzM3NzYyLWFiNTMtNGQwZC04NmEzLTQzMjE1YTY5YWY5Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzI1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyNVQyMDM2MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01YzZkMjNmZDQxMjFkN2M3YzU5ZDJhZjQ3YTQ3NDIzYTFlZDY1MWNkMGQ1Y2NlYTU0MDU2ZDlhYjk0ZDkzZThkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.T9YNJxy4ZGQ5cn_NF1xE-RsPBavbEE9HahCiws3Pd2c)
brave://settings/privacy
:since the password block is hidden in
brave://settings/safetyCheck
.I have confirmed that no network requests are triggered by this, so it may be a local check for bad passwords, I'm not sure.
Steps to reproduce
brave://settings/privacy
and scroll down to Safety Check.brave://password-manager/passwords
.facebook.com
: username =foo
and password =bar
(note: it appears to require a bad password to trigger).brave://settings/privacy
and scroll down to Safety Check.Actual result
Expected result
Reproduces how often
Easily reproduced
Brave version (brave://version info)
Channel information
Reproducibility
Miscellaneous information
No response
The text was updated successfully, but these errors were encountered: