Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merriam-Webster Resources Blocked #4054

Closed
jonathansampson opened this issue Apr 9, 2019 · 3 comments
Closed

Merriam-Webster Resources Blocked #4054

jonathansampson opened this issue Apr 9, 2019 · 3 comments
Labels
feature/shields/adblock Blocking ads & trackers with Shields feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/shields Shields is breaking a website. workaround/shields-down

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Apr 9, 2019

Description

First-party resources are blocked on www.merriam-webster.com in some builds of Brave.

image

Steps to Reproduce

  1. Navigate to www.merriam-webster.com

Actual result:

The following resources are being blocked:

Expected result:

First-party content (particularly images) should not be blocked.

Reproduces how often:

Always.

Brave version (brave://version info)

0.63.34

Reproducible on current release:

The issue does not reproduce on 0.62.51, but does reproduce on 0.63.34.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Is the issue reproducible on the latest version of Chrome? No.

Additional Information

Originally reported on Twitter:

image

@jonathansampson jonathansampson added feature/shields The overall Shields feature in Brave. feature/shields/adblock Blocking ads & trackers with Shields webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/shields-down labels Apr 9, 2019
@jonathansampson
Copy link
Contributor Author

For comparison, here is the output when viewing the same resource in Chrome with uBlock Origin 1.18.16:

+0 www.merriam-webster.com 1 image https://www.merriam-webster.com/favicon.png
+0 www.merriam-webster.com 1 image https://www.merriam-webster.com/favicon.png
+0 ##.abl www.merriam-webster.com dom https://www.merriam-webster.com/dictionary/nuance
+0 ||stats.merriam-webster.com^ -- www.merriam-webster.com 1 xhr https://stats.merriam-webster.com/tally.php?word=nuance&t=1554791010
+0 /stats/lookup? -- www.merriam-webster.com 1 xhr https://www.merriam-webster.com/lapi/v1/mwol-search/stats/lookup?rp=dictionary&usp=nuance&r=&ua=Mozilla%2F5.0%20(Windows%20NT%2010.0%3B%20Win64%3B%20x64)%20AppleWebKit%2F537.36%20(KHTML%2C%20like%20Gecko)%20Chrome%2F73.0.3683.86%20Safari%2F537.36
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/audio.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/show-less.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/show-more.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/audio.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/social-icons/double-arrows.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/social-icons/time-traveler.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/social-icons/twitter.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/social-icons/facebook.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/show-less.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/show-more.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/show-less.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/show-more.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/audio.svg
+0 www.merriam-webster.com 1 xhr https://www.merriam-webster.com/images/audio.svg
+0 ||stats.merriam-webster.com^ -- www.merriam-webster.com 1 script https://stats.merriam-webster.com/pop-score-redesign.php?id=popularity-score&word=nuance&t=1554794302783&_=1554794302685
+0 google-analytics.com/analytics.js << www.merriam-webster.com script https://www.google-analytics.com/analytics.js
+0 ||google-analytics.com^ -- www.merriam-webster.com 3 script https://www.google-analytics.com/analytics.js
+0 www.merriam-webster.com 1 inline-script https://www.merriam-webster.com/dictionary/nuance
+0 www.merriam-webster.com 3 script https://geolocation.onetrust.com/cookieconsentpub/v1/geo/countries/EU?callback=jQuery3310289762724952076_1554794302683&_=1554794302684
+0 www.merriam-webster.com 3 css https://cdn.cookielaw.org/skins/4.4.0/default_flat_bottom_two_button_black/v2/css/optanon.css
+0 ||heapanalytics.com^ -- www.merriam-webster.com 3 script https://cdn.heapanalytics.com/js/heap-537798487.js
+0 ||amazon-adsystem.com^ -- www.merriam-webster.com 3 script https://c.amazon-adsystem.com/aax2/apstag.js
+0 www.merriam-webster.com 1 image https://www.merriam-webster.com/images/social-icons/double-arrows.svg
+0 www.merriam-webster.com 1 image https://www.merriam-webster.com/images/social-icons/time-traveler.svg
+0 www.merriam-webster.com 1 image https://www.merriam-webster.com/images/social-icons/twitter.svg
+0 www.merriam-webster.com 1 image https://www.merriam-webster.com/images/social-icons/facebook.svg
+0 www.merriam-webster.com 1 image https://www.merriam-webster.com/images/show-less.svg
+0 www.merriam-webster.com 1 image https://www.merriam-webster.com/images/show-more.svg
+0 www.merriam-webster.com 1 image https://www.merriam-webster.com/images/audio.svg
+0 ##+js(abort-on-property-write.js, adonisHash) www.merriam-webster.com dom https://www.merriam-webster.com/dictionary/nuance
+0 googletagservices.com/gpt.js << www.merriam-webster.com script https://www.googletagservices.com/tag/js/gpt.js
+0 ||googletagservices.com/tag/js/gpt.js$script -- www.merriam-webster.com 3 script https://www.googletagservices.com/tag/js/gpt.js
+0 ||indexww.com^ -- www.merriam-webster.com 3 script https://js-sec.indexww.com/ht/htw-merriam-webster.js
+0 www.merriam-webster.com 1 css https://www.merriam-webster.com/assets/mw/app-bundles/mw-2019-04-08.11-29-23.000000-app-bundle/css/style-dsp-redesign-definitions.min.css
+0 www.merriam-webster.com 1 css https://www.merriam-webster.com/assets/mw/app-bundles/mw-2019-04-08.11-29-23.000000-app-bundle/css/style-dsp-redesign-definitions-defer.min.css
+0 www.merriam-webster.com 3 css https://fonts.googleapis.com/css?family=Lato:300,400,700|Open+Sans:300,300i,400,400i,600,700,700i|Playfair+Display:400,700,700i
+0 ||merriam-webster.com^$csp=script-src 'self' * 'unsafe-inline' -- www.merriam-webster.com 1 csp https://www.merriam-webster.com/dictionary/nuance
+0 www.merriam-webster.com 1 doc https://www.merriam-webster.com/dictionary/nuance

@rebron rebron added webcompat/shields Shields is breaking a website. and removed webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Apr 12, 2019
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 12, 2019
@Brave-Matt
Copy link

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels May 10, 2019
@bbondy
Copy link
Member

bbondy commented May 11, 2019

Fixed here:
brave-experiments/ad-block@03c18b3

Turns out to be a parsing bug only, and we don't parse from our clients (we only deserialize), so I was able to fix it by just re-generating the lists. If you don't see it working, just restart your browser and that should force an update check for the new serialized list.

@bbondy bbondy closed this as completed May 11, 2019
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/shields Shields is breaking a website. workaround/shields-down
Projects
None yet
Development

No branches or pull requests

4 participants