Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong colors when changing system colors to Light #4059

Closed
btlechowski opened this issue Apr 10, 2019 · 5 comments · Fixed by brave/brave-core#2219
Closed

Wrong colors when changing system colors to Light #4059

btlechowski opened this issue Apr 10, 2019 · 5 comments · Fixed by brave/brave-core#2219
Assignees
@simonhong
Labels
OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include web-ui
Milestone
0.65.x - Release ...

Comments

@btlechowski
Copy link
Collaborator

Follow up to #3881

Steps to Reproduce

  1. Change system colors to Dark
  2. Clean install Brave
  3. Go to brave://settings/
  4. Change Brave colors to Same as Windows
  5. Change system colors to Light

Actual result:

image

IMPORTANT: Browser restart fixes the issue

Expected result:

image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.63.35 Chromium: 74.0.3729.61 (Official Build) beta (64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Windows 10 OS Build 17134.523

cc @brave/legacy_qa @petemill @simonhong
@btlechowski btlechowski mentioned this issue Apr 10, 2019
Closed
@rebron rebron added this to Untriaged backlog in Front End Apr 10, 2019
@kjozwiak
Copy link
Member

Looks like we'll want to get this fixed in 0.63.x before it makes it into the release channel.

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 12, 2019
@rebron
Copy link
Collaborator

rebron commented Apr 12, 2019

related to #4056 it looks like.

@simonhong simonhong self-assigned this Apr 14, 2019
@simonhong simonhong mentioned this issue Apr 14, 2019
Merged
19 tasks
@simonhong simonhong added this to the 0.66.x - Nightly milestone Apr 24, 2019
@simonhong simonhong moved this from Untriaged backlog to Completed in Front End Apr 24, 2019
@rebron
Copy link
Collaborator

rebron commented Apr 25, 2019

@simonhong Can we include this for 64.x/65.x too?

@simonhong
Copy link
Member

@rebron yep, I already pushed two uplift PRs.

@simonhong simonhong mentioned this issue May 2, 2019
Closed
This was referenced May 3, 2019
Closed
Merged
@simonhong simonhong modified the milestones: 0.66.x - Dev, 0.65.x - Beta May 10, 2019
@kjozwiak kjozwiak mentioned this issue May 10, 2019
Closed
@GeetaSarvadnya
Copy link
Collaborator

Verification passed on

Brave 0.65.92 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523
  • Verified the STR mentioned in the description

@LaurenWags LaurenWags mentioned this issue May 31, 2019
Closed
@rebron rebron removed this from Completed in Front End Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include web-ui
Projects
None yet
Milestone
0.65.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Make proper native theme observer gets native theme change noti brave/brave-core
6 participants
@kjozwiak @rebron @simonhong @LaurenWags @btlechowski @GeetaSarvadnya