Add regional adblock

[bbondy]

No description provided.

[emerick]

Merged here:
brave/brave-core@2242c6c

[srirambv]

chrome://adblock shows regional ad block disabled.

@bbondy expected until the adblock UI is ready?

[emerick]

@srirambv To enable Regional Ad Block, you need to set Brave's language to non-English using chrome://settings/languages. For instance, when I set my language to French, I see the following in chrome://adblock

Total Ads Blocked: 119
Regional Ad Block: Enabled
FRA: EasyList Liste FR

[bbondy]

That's all that's expected for now, thx for checking

[btlechowski]

Verification passed on

Brave	0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Windows 7

[srirambv]

@emerick this doesn't work on Linux. It doesn't show an option to Set what language is used to display. Having only French as the browser language it still shows as disabled. I'll add a new issue specific to Linux.

[emerick]

@srirambv It seems that on Linux, this is controlled via the LANGUAGE environment variable (see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/D6Eoeh0G9Y4 for the gory details).

When launching on Linux like this, I saw the expected settings in chrome://adblock:

LANGUAGE=fr_FR ./brave

[bsclifton]

@emerick @bbondy I recently did country detection for Muon and noticed that the code you used @emerick doesn't always return country. For example, if you're in Columbia, I think it returns es-419 (Spanish spoken in Latin America / Caribbean)

Should regional adblocking be using language or country? Some locales returned (like fr-FR) DO specify the country, so locale may be specific enough in most cases

[bbondy]

I believe in a followup I changed it so that if the full string is not found, it uses just the smaller part without the dash.

[LaurenWags]

Verified that changing setting noted here #41 (comment) does not work for macOS. However, if I change that setting, my region, and my language as per #1238 (comment) then I can see that Regional Adblock is enabled.

Verified with

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X

[emerick]

Yes, it looks like Windows is the special case where regional ad block can be fully controlled via the browser. On Mac and Linux, it relies on system level settings.

[srirambv]

Verification Passed on

Brave	0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision	28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS	Linux