Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling SafeBrowsing in Tor #4335

Closed
jumde opened this issue May 7, 2019 · 2 comments · Fixed by brave/brave-core#2375
Closed

Disabling SafeBrowsing in Tor #4335

jumde opened this issue May 7, 2019 · 2 comments · Fixed by brave/brave-core#2375
Assignees
@jumde
Labels
feature/safebrowsing feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor privacy/connect This requires making a network connection to a third-party service. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include security
Milestone
0.64.x - Release ...

Comments

@jumde
Copy link
Contributor

jumde commented May 7, 2019 •
edited
Loading

Discussion here: https://bravesoftware.slack.com/archives/C85NV6NSG/p1557240084056200

Test Plan

Specified here: brave/brave-core#2375
@jumde jumde self-assigned this May 7, 2019
@jumde jumde mentioned this issue May 7, 2019
Merged
28 tasks
@diracdeltas diracdeltas added security privacy/connect This requires making a network connection to a third-party service. feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. labels May 7, 2019
@diracdeltas diracdeltas mentioned this issue May 8, 2019
Closed
@jumde jumde added this to the 0.67.x - Nightly milestone May 8, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 13, 2019 •
edited by srirambv
Loading

Verification passed on

Brave 0.64.75 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Verification PASSED on macOS 10.14.4 x64 using the following build:

Brave 0.64.75 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • went through the original test case outlined under Issue 4335: Disable SafeBrowsing in Tor brave-core#2375
  • ensured that safebrowsing.brave.com was contacted and the correct files were downloaded
  • ensured that all the links worked as expected under testsafebrowsing.appspot.com in both the Webpage Warnings & Desktop Download Warnings sections in a normal window
  • ensured that all the links on testsafebrowsing.appspot.com while using Tor worked and didn't display any Safe Browsing errors for both Webpage Warnings & Desktop Download Warnings
  • ensured that sb-ssl.google.com wasn't contacted using LittleSnitch

Verification passed on

Brave 0.64.75 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux
  • Verified all safe browsing links open in Tor window
  • Verified no connection to sb-ssl.google.com is done when using Tor window

@kjozwiak
Copy link
Member

Moving this into the 0.64.x milestone as this was merged into 0.64.x via brave/brave-core#2404.

@kjozwiak kjozwiak mentioned this issue May 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumde jumde

Labels
feature/safebrowsing feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor privacy/connect This requires making a network connection to a third-party service. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include security
Projects
None yet
Milestone
0.64.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Issue 4335: Disable SafeBrowsing in Tor brave/brave-core
6 participants
@fmarier @diracdeltas @jumde @kjozwiak @srirambv @GeetaSarvadnya