Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to show or hide New Tab Page widgets #4510

Closed
rebron opened this issue May 20, 2019 · 2 comments
Closed

Add options to show or hide New Tab Page widgets #4510

rebron opened this issue May 20, 2019 · 2 comments

Comments

@rebron
Copy link
Collaborator

rebron commented May 20, 2019

Test plan

See #4510 (comment)

Description

Provide users with the ability to show/hide the individual elements on the New Tab page: Brave Stats, Clock, Top Sites.

Designs

Hover or tab over the Brave Stats widget to highlight it and display an icon representing menu options:

r1 toggle widgets - stats 1

Clicking/selecting the icon shows a menu with widget options:

r1 toggle widgets - stats 2

Hover or tab over the Clock widget to highlight it and display an icon representing menu options:

r1 toggle widgets - clock 1

Clicking/selecting the icon shows a menu with widget options:

r1 toggle widgets - clock 2

Hover or tab over the Top Sites widget to highlight it and display an icon representing menu options:

r1 toggle widgets - top sites 1

Clicking/selecting the icon shows a menu with widget options:

r1 toggle widgets - top sites 2

The user can add widgets back to new tab page via the Dashboard Settings menu:

r1 toggle widgets - panel 1

When the user has removed a widget, its corresponding toggle in the Dashboard settings menu is toggled off. This is an example of how the Dashboard would look with everything toggled off:

r1 toggle widgets - panel 2

Design Specs

The user can right click anywhere on the widget to bring up the same options menu:

r1 toggle widgets - specs 2

r1 toggle widgets - specs 1

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 20, 2019
@rebron rebron added this to P3, P4 backlog in New Tab page May 20, 2019
@rebron rebron moved this from P3, P4 backlog to In progress in New Tab page May 30, 2019
@bsclifton bsclifton added this to the 0.69.x - Nightly milestone Jul 3, 2019
imptrx added a commit to brave/brave-core that referenced this issue Jul 3, 2019
imptrx added a commit to brave/brave-core that referenced this issue Jul 3, 2019
imptrx added a commit to brave/brave-core that referenced this issue Jul 3, 2019
@imptrx
Copy link

imptrx commented Jul 3, 2019

Test Plan:

  1. Open new tabs page with a fresh profile - all NTP elements should appear
  2. Open settings menu from the settings icon - 3 new settings should exist below show background
  3. Toggle the three options; show clock; show stats; show top sites - they should disappear/reappear on the page
  4. Settings should persist after browser is closed and reopened

@btlechowski
Copy link

btlechowski commented Aug 28, 2019

Awesome!

Verification passed on

Brave 0.69.117 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verified test plan from #4510 (comment)
4510

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Verified test plan from #4510 (comment)

Verified passed with

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verified test plan from #4510 (comment)

@rebron rebron changed the title show/hide New Tab Page elements Add options to show or hide New Tab Page widgets Sep 4, 2019
@rebron rebron removed this from Completed in New Tab page Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants