Respect OS storage path conventions.

[MicahZoltu]

Description

Currently, Brave is writing cache files to %APPDATA% on Windows. %APPDATA% is synced/backedup over network/internet and is meant to only contain user configuration files and other small irreplaceable data items. Brave should be writing cache files and large replaceable user data files (like scripts, executables, etc.) to %LOCALAPPDATA%, which is meant for that sort of thing.

Steps to Reproduce

Install and use Brave.

Actual result:

Large amounts of data are written to %APPDATA%.

Expected result:

%APPDATA% contains only small user-specific configuration files.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

0.64.77 Chromium: 74.0.3729.169 (Official Build) (64-bit)

Miscellaneous Information:

Please respect my hard drive and backup system!

[bsclifton]

Related: #1473

[Neustradamus]

Dear @brave team,

Have you looked for this historical problem?

Currently, user profile is saved in the bad folder.

%LOCALAPPDATA% must be replaced by %APPDATA%.

But attention, for example, Mozilla Firefox has:

• Install folder: %PROGRAMFILES%\Mozilla Firefox
• Profile folder: %APPDATA%\Mozilla\Firefox
• Cache folder: %LOCALAPPDATA%\Mozilla\Firefox

Linked to:

• Profile is stored in Local AppData folder instead of Roaming #1473
• Respect OS storage path conventions. #4609

Thanks in advance.