Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show BAT by default on main Wallet UI #4773

Closed
bbondy opened this issue Jun 10, 2019 · 1 comment · Fixed by brave/ethereum-remote-client#3
Closed

Show BAT by default on main Wallet UI #4773

bbondy opened this issue Jun 10, 2019 · 1 comment · Fixed by brave/ethereum-remote-client#3
Assignees
@ryanml
Labels
feature/ethereum-remote-client QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jun 10, 2019

Currently only Ethereum is listed, we should pre-add BAT as well.

Screen Shot 2019-06-10 at 10 26 50 AM
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Jun 10, 2019
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 11, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
1a71d39
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 11, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
cb56e03
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 11, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
93ab9b1
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 11, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
9d36048
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 12, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
7badd8d 
Adds file override task via gulp
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 14, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
1ad2e15
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 14, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
0b4b872
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 14, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
4ef8d0c
@ryanml ryanml mentioned this issue Jun 14, 2019
Merged
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 14, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
f22f488
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 14, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
7f7b483
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 14, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
64ff473
bbondy pushed a commit to brave/ethereum-remote-client that referenced this issue Jun 19, 2019
@ryanml @bbondy
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
538943d
bbondy pushed a commit to brave/ethereum-remote-client that referenced this issue Jun 19, 2019
@ryanml @bbondy
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
c09228f
bbondy pushed a commit to brave/ethereum-remote-client that referenced this issue Jun 19, 2019
@ryanml @bbondy
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
2ef841f
bbondy pushed a commit to brave/ethereum-remote-client that referenced this issue Jun 19, 2019
@ryanml @bbondy
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
6247994
bbondy pushed a commit to brave/ethereum-remote-client that referenced this issue Jun 19, 2019
@ryanml @bbondy
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
0690165
bbondy pushed a commit to brave/ethereum-remote-client that referenced this issue Jun 19, 2019
@ryanml @bbondy
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
dca901c
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 20, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
71880af
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jun 25, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
ace53cd
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jul 9, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
3d8f139
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jul 9, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
a510161
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jul 9, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
069ce49
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Jul 9, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
da87110
bbondy pushed a commit to brave/ethereum-remote-client that referenced this issue Aug 12, 2019
@ryanml @bbondy
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
fac8831
bbondy pushed a commit to brave/ethereum-remote-client that referenced this issue Aug 12, 2019
@ryanml @bbondy
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
048c060
@bbondy bbondy added the QA/Yes label Aug 14, 2019
@bbondy bbondy added this to the 0.70.x - Dev milestone Aug 14, 2019
This was referenced Sep 23, 2019
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 24, 2019 •
edited by kjozwiak

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

Verification *PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-26 at 3 36 57 PM

Screen Shot 2019-09-26 at 3 36 15 PM

ryanml added a commit to brave/ethereum-remote-client that referenced this issue Dec 5, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
09ddcfc
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Dec 5, 2019
@ryanml
Fixes brave/brave-browser#4773 - adds BAT token by default to accounts
24b0e13
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/ethereum-remote-client QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Adding BAT token by default to accounts, component patching work brave/ethereum-remote-client
6 participants
@bbondy @kjozwiak @ryanml @srirambv @btlechowski @GeetaSarvadnya