Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new adblock-rust library #4793

Closed
bbondy opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2569 or #5027
Closed

Use new adblock-rust library #4793

bbondy opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2569 or #5027
Assignees
Labels
priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA Pass-Win64 release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Jun 11, 2019

Description

Replace brave/ad-block with the new Rust based library.

Use https://github.com/brave/adblock-rust via https://github.com/brave/adblock-rust-ffi

Test plan

We should re-test a lot of the recently closed ad-block webcompat fixes.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 21, 2019

Verification passed on

Brave 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA Pass-Win64 release-notes/include
Projects
None yet
6 participants