Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware wallet connection notification uses Chromium icon #5058

Closed
srirambv opened this issue Jun 27, 2019 · 7 comments · Fixed by brave/brave-core#2963
Closed

Hardware wallet connection notification uses Chromium icon #5058

srirambv opened this issue Jun 27, 2019 · 7 comments · Fixed by brave/brave-core#2963
Assignees

Comments

@srirambv
Copy link
Contributor

Description

Found while verifying #4669. Connecting Trezor and visiting https://wallet.trezor.io, system shows the USB connection info for the browser which uses a Chromium icon

Steps to Reproduce

  1. Install 0.66.x build
  2. Connect Trezor to machine
  3. Visit https://wallet.trezor.io/ on Brave, Brave shows USB notification when the device is connected which uses a Chromium icon instead of Brave icon

Actual result:

Screenshot from 2019-06-25 20-27-08

Expected result:

Should use Brave icon for branding

Reproduces how often:

Somewhat easy if you know what you are doing

Brave version (brave://version info)

Noticed it on 0.66.98 but pretty sure its in all supported version

Brave 0.66.98 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes once 0.66.x goes to release
  • Can you reproduce this issue with the beta channel? Yes checked when 0.66.x was in beta
  • Can you reproduce this issue with the dev channel? Pretty sure yes
  • Can you reproduce this issue with the nightly channel? Most definitely yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor Author

Could be similar to #5008 but that is on Windows 8.1

@rebron rebron added this to Untriaged backlog in Front End Jun 28, 2019
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 5, 2019
@rebron rebron moved this from Untriaged backlog to P1 & P2 backlog in Front End Jul 16, 2019
@simonhong simonhong self-assigned this Jul 16, 2019
@simonhong
Copy link
Member

simonhong commented Jul 19, 2019

@rossmoody @petemill I think this can be fixed by replacing src/ui/message_center/vector_icons/product.icon with our ones. How to get this icon file? Only this product icon is not replaced yet.
Others(src/chrome/app/vector_icons/chromium/product.icon, src/components/omnibox/browser/vector_icons/product.icon) are already replaced.

@kjozwiak
Copy link
Member

Moved this into the Completed in Front End board as it was merged into master (0.69.x) via brave/brave-core#2963.

@LaurenWags
Copy link
Member

I don't seem to get a notification on macOS, is this one Windows only?

@srirambv
Copy link
Contributor Author

Dont think this is platform specific

@LaurenWags
Copy link
Member

Maybe @kjozwiak can check his mac, but I don't get any kind of notification on mine when connecting a hardware wallet - so I can't check this one.

@kjozwiak
Copy link
Member

kjozwiak commented Sep 4, 2019

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.122 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Screen Shot 2019-09-03 at 10 32 33 PM

Verification passed on

Brave 0.69.122 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux

Screenshot from 2019-09-16 10-05-01

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.523)

Windows doesnt show the same notification via the browser. System notification shows the device setup
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants