Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canned tweet is listing creator twice when language is not US English #5229

Closed
LaurenWags opened this issue Jul 12, 2019 · 4 comments
Closed
Labels
bug feature/rewards l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

When using Brave in a non-US country, when you select the 'Tweet' button on the Thank You banner after tipping, the canned tweet about your tip contains the creator listed twice, along with an extra 'use' (or translated equivalent).

Steps to Reproduce

Set your region to something other than United States - Australia/Australian English will work, but also reproduced this with Belgium/French (Belgium) as well.

  1. Clean profile. (Make sure you're seeing Brave in a non-us english language)
  2. Enable Rewards.
  3. Add BAT to wallet (can also use staging with a grant if needed)
  4. Go to a verified site and tip them.
  5. On the Thank You banner, select the Tweet button.
  6. Look at the canned tweet. Site, YouTube, Twitch, or Twitter creator will be listed twice, along with an extra word (use or translated equivalent) tacked on.

Actual result:

Australian English example:
Screen Shot 2019-07-12 at 9 52 21 am

French (Belgium) examples:
Screen Shot 2019-07-12 at 10 47 41

Screen Shot 2019-07-12 at 10 48 31

Screen Shot 2019-07-12 at 10 49 04

Screen Shot 2019-07-12 at 10 54 57

Expected result:

Creator should only be listed once in canned tweet, no extra 'use'.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.67.108 Chromium: 75.0.3770.100 (Build officiel) beta (64 bits)
Révision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
Système d'exploitation Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Reproduced by @GeetaSarvadnya

@GeetaSarvadnya
Copy link

The issue is Reproducible on windows 10 x64 - 0.67.108 with language Hindi

image

image

@rebron rebron added l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Jul 12, 2019
@mkarolin
Copy link
Contributor

mkarolin commented Aug 2, 2019

This should be fixed by brave/brave-core#3074.

@LaurenWags
Copy link
Member Author

LaurenWags commented Aug 5, 2019

+1 from #4393 (comment) / #4393 (comment)

@NejcZdovc
Copy link
Contributor

closing as it should be fixed with brave/brave-core#3074. Let's reopen if we still see this problem

Rewards automation moved this from New Issues to Done Aug 19, 2019
@NejcZdovc NejcZdovc added this to the 0.67.x - Release milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants