Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tweet button to every Tip panel #4393

Closed
mandar-brave opened this issue May 10, 2019 · 5 comments · Fixed by brave/brave-core#2195
Closed

Add Tweet button to every Tip panel #4393

mandar-brave opened this issue May 10, 2019 · 5 comments · Fixed by brave/brave-core#2195
Assignees
@emerick
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Rewards Team
Milestone
0.67.x - Release

Comments

@mandar-brave
Copy link

mandar-brave commented May 10, 2019 •
edited by LaurenWags

Test Plan

brave/brave-core#2195

Add Tweet button to every single Tip panel as part of the tipping process.
When user has successful tipped and land on the final thank you page, add the Tweet button as an option for user to tweet.
Button launched Twitter page in a new tab.

@emerick @NejcZdovc
@mandar-brave mandar-brave added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 10, 2019
@mandar-brave mandar-brave added this to Untriaged Backlog in Rewards via automation May 10, 2019
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards May 14, 2019
@NejcZdovc NejcZdovc added this to Others in Rewards Team May 17, 2019
@emerick emerick mentioned this issue May 22, 2019
Merged
19 tasks
Rewards automation moved this from Backlog to Done May 23, 2019
Rewards Team automation moved this from Others to Closed May 23, 2019
@NejcZdovc NejcZdovc added this to the 0.67.x - Dev milestone Jun 3, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jul 11, 2019 •
edited by btlechowski

Verified passed with

Brave 0.67.107 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

@LaurenWags LaurenWags mentioned this issue Jul 30, 2019
Closed
@binoyxj
Copy link

binoyxj commented Aug 4, 2019

The text included as part of the auto-tweet is actually broken. It's having some gibberish text too.

@LaurenWags
Copy link
Member

@binoyxj You're probably experiencing #5229. there's a duplicate user handle and some extra text along with it.

@LaurenWags LaurenWags mentioned this issue Aug 5, 2019
Closed
@binoyxj
Copy link

binoyxj commented Aug 5, 2019 •
edited

@binoyxj You're probably experiencing #5229. there's a duplicate user handle and some extra text along with it.

Yup! https://imgur.com/a/tlit5tw

@LaurenWags
Copy link
Member

thanks for confirming @binoyxj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
No open projects
Rewards Team
Closed
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

Add support for Twitter tips brave/brave-core
7 participants
@binoyxj @emerick @NejcZdovc @LaurenWags @btlechowski @mandar-brave @GeetaSarvadnya