Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://welcome page background needs to be adjusted for RTL languages #5377

Closed
LaurenWags opened this issue Jul 24, 2019 · 4 comments
Closed
Labels
design A design change, especially one which needs input from the design team onboarding Front-end related to helping a new user learn about features within the browser. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #3574

Background of the brave://welcome page for right to left languages (such as Hebrew or Arabic) doesn't match those of left to right languages (English, etc).

When brave://welcome is displayed for a RTL language, the background image is only on half the page. Additionally, when you go thru the onboarding pages, the background is white, so you have a white box on a white background.

Steps to Reproduce

  1. Set language to a RTL one such as Arabic or Hebrew
  2. Clean profile, launch Brave

Actual result:

See how background is on half the page. Additionally, as you move thru the flow, the background is white on each box.
onboarding-arabic

Expected result:

Should be like the LTR languages:
onboarding-english

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Mac OS X
Brave 0.67.112 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? unsure but probably
  • Can you reproduce this issue with the nightly channel? unsure but probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@LaurenWags LaurenWags added design A design change, especially one which needs input from the design team QA/Yes onboarding Front-end related to helping a new user learn about features within the browser. labels Jul 24, 2019
@rebron rebron added this to Untriaged Backlog in General Jul 29, 2019
@rebron rebron removed this from Untriaged Backlog in General Jul 30, 2019
@rebron rebron added this to Untriaged backlog in Front End Jul 30, 2019
@rebron
Copy link
Collaborator

rebron commented Aug 9, 2019

cc: @rossmoody I believe this was fixed in 70.x?

@rossmoody
Copy link
Contributor

I'd say this is worth closing because the background doesn't exist like that anymore.

@rebron
Copy link
Collaborator

rebron commented Aug 9, 2019

Closing. Fixed in 70.x

@rebron rebron closed this as completed Aug 9, 2019
@rebron rebron added this to the 0.70.x - Nightly milestone Aug 9, 2019
@rebron rebron removed this from Untriaged backlog in Front End Aug 9, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 23, 2019

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description.

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS
  • Verified STR from description.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team onboarding Front-end related to helping a new user learn about features within the browser. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

6 participants