Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Page Scroll Bar Appearing #5520

Closed
imptrx opened this issue Aug 2, 2019 · 3 comments
Closed

Welcome Page Scroll Bar Appearing #5520

imptrx opened this issue Aug 2, 2019 · 3 comments

Comments

@imptrx
Copy link

imptrx commented Aug 2, 2019

Description

Welcome page has a scroll bar when animating the footer graphic.

Steps to Reproduce

  1. Assert that no scrollbar is visible. Since macOS hides it by default, force enable it In system preferences => General => Show Scroll Bars => Always
  2. Open brave for the first time or go to brave://welcome

Actual result:

  • welcome page is scrollable
  • scroll bar is apparent

Screen Shot 2019-08-02 at 10 33 05 AM

Expected result:

  • Scroll bars should always be hidden

Reproduces how often:

  • Always

Miscellaneous Information:

  • Scroll bar must be turned on in OS settings
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 23, 2019

@cezaraugusto Is this specific to macOS?

@btlechowski
Copy link

btlechowski commented Sep 24, 2019

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

Not sure about turning on the scrollbars, but the scrollbars are not visible on welcome page.

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR mentioned in the description.
  • There is no scroll bar in the welcome screen

image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
  • ensured there wasn't any scroll bars visible under the brave://welcome screen.

@cezaraugusto
Copy link
Contributor

hi @GeetaSarvadnya I updated the test plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment