🐛 Welcome: Remove vertical scroll bars during animation: fixes brave/…

…brave-browser#5520
brave · Aug 2, 2019 · 5b1957d · 5b1957d
1 parent ab716ad
commit 5b1957d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/components/brave_welcome_ui/components/wrapper/index.ts b/components/brave_welcome_ui/components/wrapper/index.ts
@@ -86,6 +86,7 @@ export const Content = styled<ContentProps, 'section'>('section')`
 `
 
 export const Page = styled<{}, 'div'>('div')`
+  position: absolute;
   width: inherit;
   height: inherit;
   display: flex;

diff --git a/components/brave_welcome_ui/containers/app.tsx b/components/brave_welcome_ui/containers/app.tsx
@@ -85,10 +85,10 @@ export class WelcomePage extends React.Component<Props, State> {
     const { welcomeData, actions } = this.props
     return (
       <>
-        <BackgroundContainer>
-          <Background/>
-        </BackgroundContainer>
         <Page id='welcomePage'>
+          <BackgroundContainer>
+            <Background/>
+          </BackgroundContainer>
           <Panel>
             <SlideContent>
               <WelcomeBox index={1} currentScreen={this.currentScreen} onClick={this.onClickLetsGo} />

diff --git a/components/brave_welcome_ui/stories/page/index.tsx b/components/brave_welcome_ui/stories/page/index.tsx
@@ -119,10 +119,10 @@ export default class WelcomePage extends React.PureComponent<Props, State> {
     const { isDefaultSearchGoogle } = this.props
     return (
       <>
-        <BackgroundContainer>
-          <Background />
-        </BackgroundContainer>
         <Page>
+          <BackgroundContainer>
+            <Background />
+          </BackgroundContainer>
           <Panel>
             <SlideContent>
               <WelcomeBox index={1} currentScreen={currentScreen} onClick={this.onClickLetsGo} />