Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bookmarks bar visible on New Tabs Page by default #5781

Closed
simonhong opened this issue Aug 23, 2019 · 3 comments · Fixed by brave/brave-core#3251
Closed

Make bookmarks bar visible on New Tabs Page by default #5781

simonhong opened this issue Aug 23, 2019 · 3 comments · Fixed by brave/brave-core#3251

Comments

@simonhong
Copy link
Member

As brave/brave-core#2869 is merged, user can choose whether bookmark bar is visible or not on NTP regardless of bookmark show option.

By default bookmark bar is off on NTP.
It should be visible by default.

@rebron rebron added feature/settings feature/new-tab priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 23, 2019
@rebron
Copy link
Collaborator

rebron commented Aug 23, 2019

Flagged this as a p2 to evaluate. We may want to include as part of hotfix with 68.x.
@kjozwiak @bsclifton

@simonhong simonhong self-assigned this Aug 24, 2019
@simonhong simonhong added this to the 0.71.x - Nightly milestone Aug 24, 2019
@rebron rebron added this to P1, P2 backlog in New Tab page Aug 26, 2019
@rebron rebron added this to P1 & P2 Backlog in Settings Aug 26, 2019
@rebron rebron moved this from P1 & P2 Backlog to Completed in Settings Aug 27, 2019
@rebron rebron moved this from P1, P2 backlog to Completed in New Tab page Aug 27, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 2, 2019

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

@rebron rebron removed this from Completed in New Tab page Oct 1, 2019
@rebron rebron changed the title Make visible bookmark bar on NTP by default Make bookmarks bar visible on New Tabs Page by default Oct 2, 2019
@rebron rebron removed this from Completed in Settings Oct 8, 2019
@jernejml
Copy link

jernejml commented Dec 2, 2020

This setting's default value should be set to off.
Scenario:

  • you are preparing to share your screen (for example: presentation to your business partners or coworkers)
  • you disable show bookmarks
  • during presentation you open new tab
  • your coworkers suddenly realize you like to read tabloid about celebrities or even worse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants