Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session cookies interact badly with "continue where you left off" #5948

Open
fmarier opened this issue Sep 9, 2019 · 3 comments
Open

Session cookies interact badly with "continue where you left off" #5948

fmarier opened this issue Sep 9, 2019 · 3 comments
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. privacy

Comments

@fmarier
Copy link
Member

fmarier commented Sep 9, 2019 •
edited

There is apparently a bad interaction between session cookies and the "On start-up, continue where you left off" feature in Chrome. That feature resurrects the session cookies instead of letting them expire at shutdown: https://textslashplain.com/2019/06/24/surprise-undead-session-cookies/
@fmarier fmarier added the privacy label Sep 9, 2019
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 24, 2019
@bsclifton
Copy link
Member

@fmarier could this be causing any session loss? ex: #4416

@fmarier
Copy link
Member Author

fmarier commented Oct 28, 2019

This issue is more or less the opposite: we should see the user getting logged out when closing and restarting the browser, but we don't, which means that session-only cookies persist beyond a browsing session.

@tildelowengrimm tildelowengrimm added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 19, 2020
@pes10k pes10k mentioned this issue Mar 12, 2020
Closed
@fmarier
Copy link
Member Author

fmarier commented Mar 12, 2020

Things that should probably preserve session cookies:

  • restarting because of an upgrade
  • restarting because of a crash
  • restarting after changing a flag in chrome://flags

@pes10k pes10k added priority/P3 The next thing for us to work on. It'll ride the trains. and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. privacy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pes10k @fmarier @tildelowengrimm @bsclifton