Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Dapp sites to install opens a blank brave://wallet page #6279

Closed
srirambv opened this issue Oct 2, 2019 · 2 comments
Closed

Allowing Dapp sites to install opens a blank brave://wallet page #6279

srirambv opened this issue Oct 2, 2019 · 2 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 2, 2019

Description

Allowing Dapp sites to install opens a blank brave://wallet page

Steps to Reproduce

  1. Launch a new profile on 0.69.131
  2. Visit https://cryptokitties.co/
  3. Click Allow from extension install modal
  4. New tab opens brave://wallet which loads and stops no UI shown
  5. Reload page, UI shows up

Actual result:

wallet_no_ui.zip

Expected result:

Should load the UI when the tab is opened

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @bbondy @ryanml

@srirambv srirambv changed the title Allowing Daap sites to install opens a blank brave://wallet page Allowing Dapp sites to install opens a blank brave://wallet page Oct 2, 2019
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. intermittent-issue labels Oct 2, 2019
@bbondy bbondy added this to Backlog in Wallet via automation Dec 20, 2019
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Dec 20, 2019
@ryanml ryanml self-assigned this Jan 31, 2020
@ryanml ryanml added this to the Ethereum Remote Client 1.0.16 milestone Jan 31, 2020
@ryanml
Copy link
Contributor

ryanml commented Jan 31, 2020

@srirambv I am closing this one as I cannot reproduce on release or current e-r-c builds. I have added it to the next milestone and it can be confirmed as part of next week's QA

@srirambv
Copy link
Contributor Author

Still reproduces on current release component with steps from #8121. Going to move it out of milestone as #8121 is going to supersede this issue

@srirambv srirambv added closed/not-actionable and removed QA/Yes bug intermittent-issue priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Feb 11, 2020
@srirambv srirambv removed this from the Ethereum Remote Client 1.0.16 milestone Feb 11, 2020
@bbondy bbondy moved this from Done to Shipped in Wallet Mar 6, 2020
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
@srirambv srirambv removed this from Closed in Wallet Sep 24, 2021
@srirambv srirambv added this to Untriaged in Ethereum Remote Client Extension via automation Sep 24, 2021
@srirambv srirambv moved this from Untriaged to Closed/Shipped in Ethereum Remote Client Extension Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants