Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting Setup from notification bar opens a blank wallet page #8121

Closed
srirambv opened this issue Feb 7, 2020 · 2 comments · Fixed by brave/brave-core#5513
Closed

Selecting Setup from notification bar opens a blank wallet page #8121

srirambv opened this issue Feb 7, 2020 · 2 comments · Fixed by brave/brave-core#5513

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 7, 2020

Description

Selecting Setup from notification bar opens a blank wallet page

Steps to Reproduce

  1. Clean install 1.6.7
  2. VIsit cryptokitties.co and trigger notification bar to setup web3 provider
  3. Click on setup, opens a blank brave://wallet page. Need to reload the page to show the actual wallet page

Actual result:

web3setup

Expected result:

Should load the page on first launch

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.6.7 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the dev channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv srirambv added this to Untriaged in Wallet via automation Feb 7, 2020
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 7, 2020
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Feb 7, 2020
Wallet automation moved this from Backlog to Done May 15, 2020
@bbondy bbondy added this to the 1.11.x - Nightly milestone May 15, 2020
@srirambv
Copy link
Contributor Author

Moving to 1.10.x Beta as brave/brave-core#5624 is uplifted

@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2020

Verification PASSED on macOS 10.15.5 Catalina x64 using the following build:

Brave | 1.10.81 Chromium: 81.0.4044.138 (Official Build) beta (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.15.5 (Build 19F101)

Verification passed on

Brave 1.10.82 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified in #9757 (comment)

Verification passed on

Brave | 1.10.84 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

@bbondy bbondy moved this from Done to Shipped in Wallet Mar 14, 2021
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
@srirambv srirambv removed this from Closed in Wallet Sep 23, 2021
@srirambv srirambv added this to Untriaged in Ethereum Remote Client Extension via automation Sep 23, 2021
@srirambv srirambv moved this from Untriaged to Closed/Shipped in Ethereum Remote Client Extension Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants