web3 sites on private window triggers wallet association on normal window

[srirambv]

Description

web3 sites on private window trigger wallet association on normal window

Steps to Reproduce

1. Enable CW
2. Open a private tab and visit cryptokitties.co
3. Page shows wallet locked
4. Open CW page in normal window, triggers extension connect modal

Actual result:

MM doesn't trigger the same. Without CW being enabled prompts install CW modal. Enable breaks website similar to #6301

Expected result:

Extension should not be detected when a web3 site is visited without CW being enabled. As it is brave://wallet fails on private window even though its enabled in settings

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Linux

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @bbondy @ryanml @tomlowenthal

[tildelowengrimm]

I think it should be possible to use Crypto Wallets in a private window, just like it's possible to download files or add bookmarks. But this is suggesting to me that we probably need a "Enable Crypto Wallets in private windows" switch somewhere, and that it should default to off.

[NumDeP]

Above comment sort of references this #7496 and this #7497.

[joshxyzhimself]

https://news.ycombinator.com/item?id=23442027

[bsclifton]

@joshxyzhimself for more info on that, please see #10129

This issue is for a specific bug with web3 on a private window