Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infobar has blue brave logo #6478

Closed
petemill opened this issue Oct 15, 2019 · 1 comment · Fixed by brave/brave-core#3844
Closed

Infobar has blue brave logo #6478

petemill opened this issue Oct 15, 2019 · 1 comment · Fixed by brave/brave-core#3844
Assignees
@petemill
Labels
branding priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.0.0 - Release

Comments

@petemill
Copy link
Member

petemill commented Oct 15, 2019 •
edited by bsclifton

image

Test plan / STR

  • Fresh profile
  • Launch Brave
  • Quit Brave
  • Launch Brave again
  • An infobar is shown about Brave being the default browser
  • Expected: Brave logo is red and white
  • Actual: Brave logo is blue and transparent
@petemill petemill self-assigned this Oct 15, 2019
@rebron rebron added 1.0 and removed 1.0-suggestion labels Oct 15, 2019
@rebron rebron added this to In progress in Front End Oct 23, 2019
@rebron rebron moved this from In progress to P1 & P2 backlog in Front End Oct 25, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 25, 2019
@petemill petemill mentioned this issue Oct 31, 2019
Merged
32 tasks
@bsclifton bsclifton added this to the 0.73.x - Nightly milestone Nov 1, 2019
This was referenced Nov 1, 2019
Merged
Merged
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 4, 2019 •
edited by LaurenWags

Verification passed on

Brave 0.71.108 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
    image

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description

image

Verified passed with

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description for both light and dark themes:

Screen Shot 2019-11-04 at 11 52 21 AM

Screen Shot 2019-11-04 at 11 50 58 AM

@rebron rebron moved this from P1 & P2 backlog to Completed in Front End Nov 8, 2019
@rebron rebron removed this from Completed in Front End Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
branding priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging a pull request may close this issue.

Infobar colors brave/brave-core
6 participants
@petemill @bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya