Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAT icon in URL bar is misplaced when not rewards user and screen is 100% scaling #6663

Closed
btlechowski opened this issue Oct 30, 2019 · 7 comments · Fixed by brave/brave-core#3830

Comments

@btlechowski
Copy link

btlechowski commented Oct 30, 2019

This is a recent regression

Steps to Reproduce

  1. Set display to 100% scaling (and quit Brave)
  2. Clean install
  3. Run Brave

Actual result:

BAT icon in URL bar is misplaced
image
image

Note: issue is not fixed after restarting the browser

Expected result:

BAT icon is not misplaced
image

image

Reproduces how often:

Always

Brave version (brave://version info)

Reproducible in

Brave 0.71.105 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS
Brave 0.72.112 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

Not reproducible in

Brave 0.72.111 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

cc @NejcZdovc
cc @brave/legacy_qa to check on other platforms

@LaurenWags
Copy link
Member

This isn't reproducing for me on macOS with 0.71.x. I wonder if it's only related to default dark theme? Changing my theme to dark does not have an issue. I am unable to check dark theme by default though.

Brave 0.71.105 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-10-30 at 10 29 17 AM

Screen Shot 2019-10-30 at 10 30 33 AM

@btlechowski
Copy link
Author

Reproduces on Beta on Ubuntu

Brave 0.71.105 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

image

@petemill petemill self-assigned this Oct 30, 2019
@petemill petemill added this to the 0.71.x - Beta milestone Oct 30, 2019
@petemill
Copy link
Member

Likely introduced with brave/brave-core#3698

@petemill petemill added the 1.0 label Oct 30, 2019
@petemill
Copy link
Member

petemill commented Oct 30, 2019

hmm, I'm so far not able to reproduce on ubuntu (or any platform), which makes sense as it didn't happen on my linux setup during development.

image

@petemill
Copy link
Member

I can reproduce this now. Happens only when scaling is 100%, but does happen on all platforms. This is macOS:

image

Modifying title appropriately.

@petemill petemill changed the title BAT icon in URL bar is misplaced when notification is available BAT icon in URL bar is misplaced when not rewards user and screen is 100% scaling Oct 30, 2019
@petemill petemill moved this from New Issues to Review/QA in Rewards Oct 30, 2019
Rewards automation moved this from Review/QA to Done Oct 31, 2019
@LaurenWags
Copy link
Member

QA/Blocked until 0.71.108 or above.

@btlechowski
Copy link
Author

btlechowski commented Nov 4, 2019

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Ubuntu 18.04 LTS

Verified STR from the description.

image

Verification passed on

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
    image

Verified passed with

Brave 0.71.111 Chromium: 78.0.3904.87 (Official Build) (64-bit)
Revision 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified the STR from description

Screen Shot 2019-11-04 at 1 42 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment