Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Ads and trackers to Ads & trackers to match mobile #6982

Closed
srirambv opened this issue Nov 18, 2019 · 2 comments
Closed

Rename Ads and trackers to Ads & trackers to match mobile #6982

srirambv opened this issue Nov 18, 2019 · 2 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.

Comments

@srirambv
Copy link
Contributor

Description

Based on @karenkliu comment on brave/brave-ios#1575 (comment), desktop should match what's on mobile and replace Ads and Trackers blocked to Ads & Trackers blocked

Actual result:

Ads and Trackers blocked

Expected result:

Ads & Trackers blocked

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@srirambv srirambv mentioned this issue Nov 18, 2019
Closed
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Nov 21, 2019
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed QA/Yes feature/new-tab feature/user-interface All UI related labels Feb 9, 2021
@rebron
Copy link
Collaborator

rebron commented Feb 9, 2021

Closing as stale. We're consistent across all platforms as Trackers & ads Blocked. We're lower case ads on desktop though.

@rebron rebron closed this as completed Feb 9, 2021
@rebron rebron removed priority/P4 Planned work. We expect to get to it "soon". release-notes/exclude labels Feb 9, 2021
@karenkliu
Copy link

karenkliu commented Feb 9, 2021 •
edited
Loading

Yes, consistent on all platforms as Trackers & ads blocked. Only iOS retains Title Case by choice - Trackers & Ads Blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karenkliu @rebron @srirambv