Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR panel contents are not scaled properly #7147

Closed
GeetaSarvadnya opened this issue Nov 28, 2019 · 5 comments · Fixed by brave/brave-core#4735
Closed

BR panel contents are not scaled properly #7147

GeetaSarvadnya opened this issue Nov 28, 2019 · 5 comments · Fixed by brave/brave-core#4735

Comments

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Nov 28, 2019

Description

BR panel contents are not scaled properly

Steps to Reproduce

STR1:

  1. Launch clean profile 1.3.38 with staging flags
  2. Enable rewards and claim grants
  3. Click on the hamburger menu and exit the browser
  4. Relaunch browser without staging flag
  5. Click on Claim grants from NTP widget
  6. Place the source triangle to the appropriate target
  7. BR panel contents are not scaled properly

STR2:

  1. Launch clean profile 1.0.1 with staging flag
  2. Enable rewards and claim grants in BR panel
  3. Place the source triangle to the appropriate target in BR panel
  4. BR panel contents are not scaled properly

Actual result:

BR panel contents are not scaled properly
Nightly:
image

Release:
image

Expected result:

BR panel contents should be scaled properly

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.3.38 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @ryanml @rebron

Windows 10 X64 - DPI is as below
image

@zenparsing
Copy link
Collaborator

Although I was unable to reproduce the error on master and release (1.4.95), I was able to confirm the same root cause as #7597.

@NejcZdovc
Copy link
Contributor

@zenparsing will fix for #7597 fix this one as well?

@zenparsing
Copy link
Collaborator

@NejcZdovc it will

@NejcZdovc
Copy link
Contributor

please add it to PR so that PR will auto close this issue, just add new line with Resolves and link to this issue

@NejcZdovc NejcZdovc moved this from Backlog to Review/QA in Brave Rewards Feb 29, 2020
Brave Rewards automation moved this from Review to Done Mar 4, 2020
@zenparsing zenparsing added this to the 1.7.x - Nightly milestone Mar 4, 2020
@btlechowski
Copy link
Collaborator

btlechowski commented Mar 18, 2020

Verification passed on

Brave 1.7.65 Chromium: 80.0.3987.132 (Official Build) dev (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS

image

More verification done in: #7597

Verification passed on

Brave 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description

image

image

Verified passed with

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment