Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Brave branded icons for Bookmarks manager #7312

Open
srirambv opened this issue Dec 10, 2019 · 6 comments
Open

Use Brave branded icons for Bookmarks manager #7312

srirambv opened this issue Dec 10, 2019 · 6 comments
Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects

Comments

@srirambv
Copy link
Contributor

srirambv commented Dec 10, 2019

Description

Match the icons added for Bookmarks Toolbar here:
brave/brave-core#10037

For more info, see https://www.figma.com/file/sS3l8tqUFxt54MEiBTalUI/?node-id=9%3A5824

Should look like this:
image

Original issue description

Use Brave branded icons for history. More info here #6013 (comment)

Miscellaneous Information:

@srirambv srirambv added feature/user-interface All UI related design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude labels Dec 10, 2019
@srirambv srirambv changed the title Use Brave branded icons for history Use Brave branded icons for Bookmarks/Bookmark Folders Dec 10, 2019
@rebron rebron added this to Untriaged backlog in Front End Dec 17, 2019
@lukemulks
Copy link

I suspect this is the correct issue to post this - I'm observing a folder icon in brave://bookmarks in the left panel that appears a bit out of place. Would expect to see an icon that matches the Bookmarks icon at the top of the Bookmarks page.

Screenshot from 2020-01-07 20-40-56

Brave | 1.4.50 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
-- | --
Revision | c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS | Linux

I'm on Fedora 31

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Feb 7, 2020
@rebron
Copy link
Collaborator

rebron commented Feb 7, 2020

cc: @karenkliu

@karenkliu
Copy link

This is our own bookmarks folder icon:
icon-folder@1 5x

It replaces the Chrome bookmarks folder icon in the browser toolbar and on chrome://bookmarks/
example

Icon asset:
bookmark folder icon.zip

Also, is this issue related to #6013?

@simonhong
Copy link
Member

simonhong commented May 29, 2020

@karenkliu, Below images are needed for bookmark folder.

  • Win - 16x16 (and 32x32) folder open/closed png like chromium's
    image

  • Mac - 16x16 (and 32x32) folder/folder_white png like chromium's
    Screen Shot 2020-05-29 at 9 37 53 PMScreen Shot 2020-05-29 at 9 38 14 PM

  • Linux - 19x18 (and 38x36) folder/folder_closed png

Note - Upstream mac only uses closed image. Others are uses open/closed images. If we want to use closed for all cases, it's fine.

@karenkliu
Copy link

Hi @simonhong, here is the direct link to our bookmarks icon in Figma where you can export it as a PNG in all the needed sizes: https://www.figma.com/file/xWGBM3qWbu3RLuZqZGwynk/Icons?node-id=124%3A10713
DM me if you have trouble accessing it or exporting. Using a closed image for all cases is fine.

@rebron rebron moved this from P4 backlog to P1 & P2 backlog in Front End Jun 2, 2020
@rebron rebron moved this from P1 & P2 backlog to In progress in Front End Jun 2, 2020
@simonhong
Copy link
Member

simonhong commented Jun 2, 2020

This issue needs more changes and efforts than expected because upstream on window and linux don't use different images for folder open/closed. They use same yellow colored folder images for dark/light theme.
However, we need to use different images for dark/light theme because our default folder icon looks dark in dark theme.

@rebron rebron moved this from In progress to P4 backlog in Front End Jul 21, 2020
@simonhong simonhong removed this from the 1.13.x - Beta milestone Jul 29, 2020
@srirambv srirambv changed the title Use Brave branded icons for Bookmarks/Bookmark Folders [Desktop] Use Brave branded icons for Bookmarks/Bookmark Folders Sep 9, 2020
@simonhong simonhong self-assigned this Jun 18, 2021
@rebron rebron changed the title [Desktop] Use Brave branded icons for Bookmarks/Bookmark Folders Use Brave branded icons for Bookmarks/Bookmark Folders Jul 27, 2021
@bsclifton bsclifton changed the title Use Brave branded icons for Bookmarks/Bookmark Folders Use Brave branded icons for Bookmarks manager Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
Status: P4 backlog
Front End
  
P4 backlog
6 participants