Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Clear cache, cookies, history automatically/manually with on exit option #7487

Closed
SergeyZhukovsky opened this issue Dec 27, 2016 · 94 comments · Fixed by brave/brave-core#8790
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/global-settings Settings at browser level independent of shields settings feature/history feature-request OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Dec 27, 2016

Designs

Frame 1

Assets

Figma: https://www.figma.com/file/QqaIjdrXobryTT3Zd9wcKM/?node-id=0%3A1

@azz
Copy link

azz commented Jan 29, 2017

Is there a way to just close all tabs on exit?

@SergeyZhukovsky
Copy link
Member Author

@azz no there is no way there is an issue for that https://github.com/brave/browser-android-tabs/issues/80

@SergeyZhukovsky
Copy link
Member Author

We have probably implement that feature on app start, because Android OS could kill your app in any moment.

@SergeyZhukovsky
Copy link
Member Author

We should have a whitelist to keep all of that for certain websites.

@srirambv
Copy link
Contributor

@neroux
Copy link

neroux commented Nov 16, 2017

@SergeyZhukovsky Any update on that feature?

@SergeyZhukovsky
Copy link
Member Author

@neroux we haven't started it yet. We are working on video problems and sync features currently and will look on that after.

@neroux
Copy link

neroux commented Nov 16, 2017

Thanks for the quick response @SergeyZhukovsky. Is it still under consideration or will it be implemented? If the latter would you have any (realistic) timeframe? A month, three months, half a year, a year, ....? Thanks

@neroux
Copy link

neroux commented Dec 4, 2017

@SergeyZhukovsky, possibly any feedback regarding

Is it still under consideration or will it be implemented? If the latter, would you have any (realistic) timeframe? A month, three months, half a year, a year, ....?

Thanks a lot

@SergeyZhukovsky
Copy link
Member Author

@neroux it is hard to say, the task isn't prioritized yet, I hope it will be avail within two months.

@neroux
Copy link

neroux commented Dec 4, 2017

@SergeyZhukovsky No worries :), didnt "expect" a precise timeframe, a rough estimation like the ~2 months is more than enough. Just wanted to know whether it is going to happen at all. Thanks a lot.

@LaurenWags
Copy link
Member

@ghost
Copy link

ghost commented Feb 17, 2018

Hi all, @BraveSampson on Twitter sent me here. Would definitely like to be able to clear all browsing data on Android like in Firefox. Thanks!

@neroux
Copy link

neroux commented Feb 17, 2018

👍 @ychenier

I realise, the two months mark has only just passed, so my question might come a bit early but still curious of course .... do you think that feature will be available soon (+/- 30 days) or is it still in the making and will take some more time @SergeyZhukovsky? Thanks a lot!

@ghost
Copy link

ghost commented Feb 26, 2018

Hello! Brave dev send me here from playstore. It would be nice to clear all browsing data when the browser close! I waiting for this a long time...

@rix1337
Copy link

rix1337 commented Apr 15, 2018

I look to only disable history (not cookies) like you can on Firefox.

Should be fairly easy. Look at the Chrome desktop addon No History
https://chrome.google.com/webstore/detail/no-history/ljamgkbcojbnmcaonjokopmcblmmpfch

@ghost
Copy link

ghost commented May 11, 2018

Any progress so far? This feauture would be so useful. Sad it's not there already.

@motorious1
Copy link

also VERY interested in this feature on the mobile app...hope it comes soon.

@rix1337
Copy link

rix1337 commented May 18, 2018

How is progress on the keep history toggle? This should not be hard.

@eljuno
Copy link

eljuno commented May 31, 2018

+1 from community for history https://community.brave.com/t/recent-sites-on-homepage/23048?u=eljuno

@kjozwiak
Copy link
Member

kjozwiak commented Jun 28, 2018

+1 from a user on the brave subreddit:

https://www.reddit.com/r/brave_browser/comments/8unged/clear_history_on_exit_brave_browser_android/

Thanks for replying in that thread @eljuno 👍

@eljuno
Copy link

eljuno commented Aug 5, 2018

@Brave-Matt
Copy link

+1 from Zendesk user:

Hi, i really like the browser.. It needs one more thing.. When you exit it needs to automatically delete cookies and visited sites..
Others do this...
Keep up the good work...

@neroux
Copy link

neroux commented Aug 20, 2018

@SergeyZhukovsky, is there possibly any update on that issue? Is it still under consideration?

@neroux
Copy link

neroux commented Sep 29, 2018

@SergeyZhukovsky How are the chances it will really show up in 1.0.61? Thanks.

@SergeyZhukovsky
Copy link
Member Author

We are working on Android ledger integration and sync features. All our dev resources are there currently. It's hard to say when we will work on that, probably in couple months.

@neroux
Copy link

neroux commented Oct 3, 2018

Thanks @SergeyZhukovsky, though I am not sure what you mean by "ledger integration" exactly.

1.0.61 seems to be scheduled for the end of this month. As you said "couple of months" I guess it wont be in 1.0.61 then, right?

@kjozwiak
Copy link
Member

kjozwiak commented Oct 3, 2018

1.0.61 seems to be scheduled for the end of this month. As you said "couple of months" I guess it wont be in 1.0.61 then, right?

Yup, unfortunately this feature isn't going to be added/implemented in 1.0.61 due to the dev's concentrating on Sync and adding Payments/Rewards on mobile.

@AnirudhJambunathan
Copy link

Clearing browser data on exit is a really important feature. Please provide it at the earliest.

@Brave-Matt
Copy link

@WilliamShockleyfake
Copy link

Plz add this. Waiting for ever

@anthonypkeane
Copy link

It is available on the Beta version now and we should have it on the main app in a few weeks @WilliamShockleyfake

@WilliamShockleyfake
Copy link

It is available on the Beta version now and we should have it on the main app in a few weeks @WilliamShockleyfake

Downloading cant fucking wait. Hate YouTube and websites tracking me based on cookies

@srirambv
Copy link
Contributor

srirambv commented Jun 7, 2021

Verification passed on OnePlus 6T with Android 10 running 1.26.53 x64 Beta Build

  • Verified enabling Clear browsing data on exit removes all data upon exit
  • Verified enabling setting doesn't clear any existing tabs
  • Verified tab navigation history is cleared on restart when clear data on exit is enabled
  • Verified saved passwords are removed on restart when clear data on exit is enabled
  • Verified saved card info is removed on restart when clear data on exit is enabled
  • Verified saved address info is removed on restart when clear data on exit is enabled
  • Verified cookie is deleted on restart when clear data on exit is enabled
  • Verified site specific settings are reset to default on restart when clear data on exit is enabled
  • Encountered Global settings doesn't retain state after restart #16259 & Setting Block ads trackers to aggressive disables the setting #16260

Verification passed on Samsung Tab A with Android 10 running 1.26.53 x64 Beta Build

  • Verified enabling Clear browsing data on exit removes all data upon exit
  • Verified enabling setting doesn't clear any existing tabs
  • Verified tab navigation history is cleared on restart when clear data on exit is enabled
  • Verified saved passwords are removed on restart when clear data on exit is enabled
  • Verified saved card info is removed on restart when clear data on exit is enabled
  • Verified saved address info is removed on restart when clear data on exit is enabled
  • Verified cookie is deleted on restart when clear data on exit is enabled
  • Verified site specific settings are reset to default on restart when clear data on exit is enabled
  • Encountered Global settings doesn't retain state after restart #16259 & Setting Block ads trackers to aggressive disables the setting #16260

@bridiver
Copy link
Contributor

bridiver commented Jun 7, 2021

@srirambv Verified site specific settings are reset to default on restart when clear data on exit is enabled - not sure how that got included in the list of things to check, but it is incorrect. Also it I don't see that clearing of cookies/cache was verified.

@srirambv
Copy link
Contributor

srirambv commented Jun 8, 2021

@bridiver its mentioned in the test plan to check for site settings to be cleared brave/brave-core#8790. I missed adding the cookie/cache note but I did login to a site and then quit the browser with the setting and upon restart I was logged out. Updated the notes

@bridiver
Copy link
Contributor

bridiver commented Jun 8, 2021 via email

@newuser-web
Copy link

All data of the previous session are deleted after enabling it. It should delete the data of the current session only.

@pyrocto
Copy link

pyrocto commented Jun 25, 2021

I disagree. If you want only a single session to be deleted, use a private window.

@newuser-web
Copy link

But it shouldn't delete the data of previous months or years. I don't want only a single session to be deleted. As long as clear data on exit is enabled( it may be 1 week or 1 month) it should delete the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/global-settings Settings at browser level independent of shields settings feature/history feature-request OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.