Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Rewards button doesn't trigger relaunch prompt [Follow up to #7889] #7915

Closed
srirambv opened this issue Jan 25, 2020 · 1 comment · Fixed by brave/brave-core#4468
Closed

Comments

@srirambv
Copy link
Contributor

Description

Hide Rewards button doesn't trigger relaunch prompt. Follow up to #7889

Steps to reproduce

  1. Install Beta from GPS
  2. Skip onboarding and disable rewards button under appearance
  3. No relaunch prompt, button is still shown until manually relaunching the browser

Actual result

tablet

Expected result

Should prompt relaunch when setting is changed from default state

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? NA
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Tablet
  • Android version: 9.0

Brave version

1.5.59

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @yrliou

@srirambv srirambv added QA/Yes OS/Android Fixes related to Android browser functionality ARM Android ARM related issues android-core-release android-tablet-specific labels Jan 25, 2020
@srirambv srirambv added this to Backlog in Android General via automation Jan 25, 2020
@yrliou yrliou self-assigned this Jan 31, 2020
Android General automation moved this from Backlog to Done/Closed Jan 31, 2020
@yrliou yrliou added this to the Android Beta Release 2 milestone Jan 31, 2020
@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.6.24 nightly x64 build

  • Verified disabling rewards button prompts relaunch
  • Verified enabling rewards via chrome://rewards when icon is disabled also prompts relaunch and shows icon after relaunch

Verification passed on Samsung Tab A with Android 9 running 1.6.24 nightly x64 build

  • Verified disabling rewards button prompts relaunch
  • Verified enabling rewards via chrome://rewards when icon is disabled also prompts relaunch and shows icon after relaunch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

2 participants