Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Bookmark button gets selected when tapped next to menu button #8460

Closed
srirambv opened this issue Feb 28, 2020 · 4 comments · Fixed by brave/brave-core#5557
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 28, 2020

Description

Bookmark button gets selected when tapped next to menu button

Steps to reproduce

  1. Install 1.5.100 Beta from GPS
  2. Tap on the extreme right side of the menu button
  3. Bookmark button gets highlighted

Actual result

bookmarkstap

Expected result

No tap on bookmarks button

Issue reproduces how often

Easy

Issue happens on

  • Current Play Store version? NO
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): OnePlus 6T
  • Android version: 10

Brave version

1.5.100 Beta

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

Not a big deal but something that needs to be fixed
cc: @bbondy @SergeyZhukovsky @anthonypkeane marked it as android-related for tirage

@srirambv srirambv added about-pages/welcome about-pages/sync about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages OS/Android Fixes related to Android browser functionality labels Feb 28, 2020
@srirambv srirambv added this to Backlog in Android General via automation Feb 28, 2020
@srirambv srirambv added bug feature/user-interface All UI related QA/Yes and removed about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages about-pages/sync about-pages/welcome labels Feb 28, 2020
@deeppandya deeppandya self-assigned this Mar 10, 2020
@srirambv
Copy link
Contributor Author

srirambv commented May 4, 2020

@samartnik samartnik assigned samartnik and unassigned deeppandya May 14, 2020
Android General automation moved this from Backlog to Done/Closed May 15, 2020
@samartnik samartnik added this to the 1.11.x - Nightly milestone May 15, 2020
@samartnik samartnik added this to Backlog in Android Core 1.9 via automation May 15, 2020
@samartnik samartnik removed this from Done/Closed in Android General May 15, 2020
@srirambv
Copy link
Contributor Author

Uplift approved hence moving the issue to 1.9.x Release. Need to link the issue to Android 1.9.x release

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 22, 2020

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm.apk.1.9.74

  • Reproduced the issue in 1.5.100 Android beta version
  • The issue is fixed and working fine in 1.9.74

Verification passed on Asus Zenfone with Android version 6 running BraveModernx86.apk 1.9.74

  • Reproduced the issue in 1.5.111 Android release version
  • Verified STR from description

@btlechowski
Copy link

Marked as android-phone-specific as Tablets don't have bottom toolbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants