Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Rewards page. Multiple promotions. Claiming one starts progress spinner spinning on the next promotion. #8586

Closed
gdregalo opened this issue Mar 7, 2020 · 4 comments · Fixed by brave/brave-core#4964

Comments

@gdregalo
Copy link

gdregalo commented Mar 7, 2020

Description

Rewards page. Multiple promotions. Claiming one starts progress spinner spinning on the next promotion.

Steps to reproduce

  1. Create a wallet and get multiple promotions on it.
  2. Open rewards page and claim any but not last one in the list.
  3. Observe : promotion is received, wallet balance is updated. Spinner control starts spinning on the next promotion.

Actual result

Promotion is received, wallet balance is updated. Spinner control starts spinning on the next promotion.

Expected result

After promotion claim is finished it has to open a windows with promotion summary and OK button (similar to UGP promotion).

Issue reproduces how often

Issue happens on

  • Current Play Store version?
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@gdregalo gdregalo added bug QA/Yes OS/Android Fixes related to Android browser functionality android-core-release labels Mar 7, 2020
@gdregalo gdregalo added this to the 1.7.x - Nightly milestone Mar 7, 2020
@SergeyZhukovsky
Copy link
Member

moving it out from core release as tabs repo has a similar issue

@NejcZdovc NejcZdovc added this to New Issues in Rewards via automation Mar 13, 2020
@emerick emerick self-assigned this Mar 13, 2020
@NejcZdovc NejcZdovc added this to Backlog in Brave Rewards via automation Mar 14, 2020
@NejcZdovc NejcZdovc removed this from New Issues in Rewards Mar 14, 2020
@NejcZdovc NejcZdovc moved this from Backlog to In progress in Brave Rewards Mar 14, 2020
Brave Rewards automation moved this from In progress to Done Mar 17, 2020
@srirambv
Copy link
Contributor

srirambv commented Apr 3, 2020

Moving to Android 1.7.x miletone as this is Android specific issue

@srirambv srirambv added this to Backlog in Android General via automation Apr 3, 2020
@srirambv srirambv moved this from Backlog to Done/Closed in Android General Apr 3, 2020
@srirambv
Copy link
Contributor

Blocked on #9524

@srirambv
Copy link
Contributor

srirambv commented May 1, 2020

Verification passed on OnePlus 6T with Android 10 running 1.7.102 x64 stable build

  • Verified only once on the device, claiming one promotion doesn't start spinner on the others and doesn't claim them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Android General
  
Done/Closed
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants